Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update custom-coreos-disk-images digest to 5613490 #97

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 20, 2025

This PR contains the following updates:

Package Update Change
custom-coreos-disk-images digest f601cc0 -> 5613490

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@Luap99
Copy link
Member

Luap99 commented Mar 20, 2025

Looks like something in the coreos script broke

@Luap99 Luap99 self-assigned this Mar 20, 2025
@Luap99
Copy link
Member

Luap99 commented Mar 20, 2025

/hold
please don't merge before #98

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems good to go with #98 merged.

@@ -2,6 +2,8 @@

set -xeo pipefail

dnf up -y osbuild
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to build new images instead of running on the fly updates that can fail if the repos are down or they are some new package conflicts, this was just to test since I asked Dusty about the CI issue and he mentioned we need to update osbuild.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot changed the title Update custom-coreos-disk-images digest to 5613490 chore(deps): update custom-coreos-disk-images digest to 5613490 Mar 25, 2025
@renovate renovate bot force-pushed the renovate/custom-coreos-disk-images-digest branch from d40212b to d360eef Compare March 25, 2025 11:27
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 25, 2025
Copy link

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2ba42d8 into main Mar 25, 2025
8 checks passed
@renovate renovate bot deleted the renovate/custom-coreos-disk-images-digest branch March 25, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants