Fetch dep rpm updates #92
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
19 times, most recently
from
5b46bb8 to
8460ff5
Compare
|
Opening for review. @Luap99 @ashley-cui @baude @mheon PTAL. |
|
Err, never mind. spoke too soon. I see this in the logs: |
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
from
8460ff5 to
7b14fa1
Compare
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
2 times, most recently
from
a0f528e to
13bccc8
Compare
I think the dependency fetching looks alright now and tests pass Opening for review. |
Luap99
requested changes
Mar 25, 2025
|
@Luap99 Thanks for the comments. I'm probably gonna rework it to keep all koji ops outside of the container. Setting it back to draft. |
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
6 times, most recently
from
2b012b2 to
d0885cb
Compare
|
Good for another review. I'm keeping draft status because I need to revert PR_NUM change. |
Luap99
reviewed
Apr 2, 2025
podman-image/Containerfile
Outdated
Comment on lines
50
to
52
| rm -f crun-krun*.rpm crun-wasm*.rpm && \ | ||
| dnf -y update --best --allowerasing *.rpm && \ | ||
| rm -f *.rpm && \ |
There was a problem hiding this comment.
I don't think the removal does anything for the OCI image size as the COPY step already create a new layer AFAIK.
I guess it is still correct as we don't want "random" rpm files in the actual disk image.
I wonder if it would not be simpler to mount them instead of using COPY. I think podman build -v coul be an option or RUN --mount in the Containerfile.
There was a problem hiding this comment.
ack. I could look into that. Thanks
Sometimes, the latest podman release rpm might need other dependencies like containers-common updated as well. This PR will fetch dependencies directly from koji regardless of bodhi status. container-selinux and crun will be fetched from the default distro tags while aardvark-dns, containers-common, and netavark will be fetched from sidetags owned by packit using `koji download-build ...`. Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
from
d0885cb to
36709a6
Compare
Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
from
36709a6 to
01b18c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the latest podman release rpm might need other dependencies like containers-common updated as well.
This PR will fetch dependencies directly from koji regardless of bodhi status.
aardvark-dns, containers-common, crun and netavark will be fetched from default distro tags as well as sidetags owned by packit using
koji download-build ....NOTE: container-selinux rpm currently is facing conflicts with selinux-policy so I've skipped it for now.