e2e: fix qemu option generation and vm-setup for single node test VMs. #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omit generating extra memory parameters altogether when we are generating topology for a single node VM. Signed-off-by: Krisztian Litkey <[email protected]>
Do not expect unconditionally a non-empty EXTRA_ARGS. It will be empty when we generate a single node VM. Signed-off-by: Krisztian Litkey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set fixes
topology2qemuoptsto generate correct qemu options for single node VM topologiesvm-setup()to not expect unconditional memory-related options in EXTRA_ARGSWith these fixes in place it is now possible to generate and boot single node multi-socket test VMs.