make network setup order deterministic #1369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
force-pushed
the
network-ordered
branch
from
8e0dfb9 to
e3d4938
Compare
mheon
reviewed
Dec 3, 2025
mheon
reviewed
Dec 3, 2025
Change the file format of the networks json to use an array for the PerNetworkOptions. With that we can get a defined order in which we setup the networks and do that deterministically. In order to provide backwards compatibility we use a custom json deserializer function that accepts both the old and new format. That allows us to still use the old podman against the new netavark with this patch. I also added PartialEq trait to the types so the unit test can compare two loaded Networks. I only converted a few of our test configs to the new format to keep the diff smaller. We can convert most of them another time. Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
network-ordered
branch
from
e3d4938 to
49ee09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the file format of the networks json to use an array for the PerNetworkOptions. With that we can get a defined order in which we setup the networks and do that deterministically.
In order to provide backwards compatibility we use a custom json deserializer function that accepts both the old and new format. That allows us to still use the old podman against the new netavark with this patch.
I also added PartialEq trait to the types so the unit test can compare two loaded Networks.
I only converted a few of our test configs to the new format to keep the diff smaller. We can convert most of them another time.