Skip to content

Conversation

@aljesusg
Copy link
Contributor

Downstream we will add the following override in pkg/config/config_default_overrides.go:

ToolsetKialiName: "ossm"

This allows the toolset to return "ossm" from GetName() instead of "kiali".
think this approach works better than passing internalk8s.Openshift into GetName() the way GetTools() does, since it keeps things simpler, requires fewer modifications, and is overall lighter.

Also, each tool already checks whether the environment is OpenShift (following the same pattern as the core toolset). We expect users to run OpenShift with OSSM, not upstream Istio, so this behavior is consistent with that assumption.

Screenshot From 2025-11-26 11-14-04

cc @manusa WDYT?

@aljesusg
Copy link
Contributor Author

aljesusg commented Nov 26, 2025

Mmm I need to add some tests to verify that naming is not going to affect to the toml configuration

Ok the other hand I am thinking to use the config to tools naming too.

@aljesusg aljesusg changed the title feat(kiali): Possibility of renaming Kiali in the downstream distribution WIP feat(kiali): Possibility of renaming Kiali in the downstream distribution Nov 26, 2025
Signed-off-by: Alberto Gutierrez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant