WIP feat(kiali): Possibility of renaming Kiali in the downstream distribution #507
+437
−301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream we will add the following override in
pkg/config/config_default_overrides.go:ToolsetKialiName: "ossm"This allows the toolset to return
"ossm"fromGetName()instead of"kiali".think this approach works better than passing
internalk8s.OpenshiftintoGetName()the wayGetTools()does, since it keeps things simpler, requires fewer modifications, and is overall lighter.Also, each tool already checks whether the environment is OpenShift (following the same pattern as the
coretoolset). We expect users to run OpenShift with OSSM, not upstream Istio, so this behavior is consistent with that assumption.cc @manusa WDYT?