feat: Multi Cluster Support #348
Open
+1,299
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <[email protected]>
|
So far, this PR only adds the ClusterProvider interface and the implementation for a kubeconfig provider. The idea is that the provider can be used to get a Manager instance for the cluster requested in the tool provider. Barring any feedback against this approach, I will continue with adding the cluster parameter to tools whenever the number of clusters is > 1, and using the provider interface to get the correct manager to each tool. |
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
|
@manusa I tried to keep the changes separated out by commit to make reviewing easier, let me know if I should squash them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the approach taken in #325, but makes it more generic so that we can configure how clients select the cluster based on the cluster provider strategy (currently supporting in-cluster and kubeconfig).
There is a
contexts_listtool added as well, which is conditionally enabled when there are more than 15 contexts in the kubeconfig, as that is when we switch from using an enum parameter to a general string parameter.