Skip to content

Check for response code 200, if not 200 return error #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Check for response code 200, if not 200 return error #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d85266f
fix: check for response code 200, if not 200 return the error
cwiggs Jul 23, 2025
18b7cf6
Apply suggestions from code review
cwiggs Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/engine/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,14 @@ func downloadUpdateConfigFile(urlStr string, existsAlready, initial bool, pat, u
return false, err
}
defer resp.Body.Close()

if resp.StatusCode != http.StatusOK {
return false, fmt.Errorf("received non-200 HTTP status from %s: %d %s", urlStr, resp.StatusCode, resp.Status)
}

newBytes, err := io.ReadAll(resp.Body)
if err != nil {
return false, fmt.Errorf("error downloading config from %s: %v", err)
return false, fmt.Errorf("error downloading config from %s: %v", urlStr, err)
}
if newBytes == nil {
// if initial, this is the last resort, newBytes should be populated
Expand Down