Add ~/.local/share/containers/storage/overlay-containers to .fc (bsc#… #424

ca-hu · 2025-12-08T12:33:13Z

…1253682)

For some reason it is not listed in the file contexts, so it will show up as to be relabelled when running "restorecon":

Would relabel /home/foo/.local/share/containers/storage/overlay-containers/f857f27662ab22b7c502a531d61790b7c120dbedc70820962bb45c285aa03cc3/userdata/artifacts from unconfined_u:object_r:container_ro_file_t:s0 to unconfined_u:object_r:data_home_t:s0 Would relabel /home/foo/.local/share/containers/storage/overlay-containers/2b562de7757133521824ac9de932ddd4862d8262695998a4ee02094c14fc1277/userdata/artifacts from unconfined_u:object_r:container_ro_file_t:s0 to unconfined_u:object_r:data_home_t:s0

-containers is defined here:
https://github.com/containers/storage/blame/83cf57466529353aced8f1803f2302698e0b5cb7/store.go#L3633

Summary by Sourcery

Bug Fixes:

Prevent incorrect relabeling of ~/.local/share/containers/storage/overlay-containers paths by defining appropriate file contexts.

sourcery-ai · 2025-12-08T12:33:20Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Add SELinux file context entries for Podman/containers-storage overlay-containers paths under users' ~/.local/share directories so restorecon no longer attempts to relabel them to data_home_t.

File-Level Changes

Change	Details	Files
Define SELinux file context patterns for per-user containers-storage overlay-containers content under ~/.local/share to keep them labeled with container_ro_file_t.	Add regex-based path mapping for ~/.local/share/containers/storage/overlay-containers to container_ro_file_t Align new path definition with existing -containers convention used by containers/storage	`container.fc`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist · 2025-12-08T12:33:25Z

Summary of Changes

Hello @ca-hu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an SELinux relabeling problem affecting user-specific container storage. By explicitly defining the correct file contexts for overlay-containers and overlay2-containers within the container.fc configuration, it ensures that restorecon maintains the intended container_ro_file_t context. This prevents unnecessary and potentially problematic security context changes, thereby improving the stability and correctness of SELinux enforcement for container users.

Highlights

SELinux File Context: Added SELinux file context rules for ~/.local/share/containers/storage/overlay-containers and ~/.local/share/containers/storage/overlay2-containers to the container.fc file.
Relabeling Issue Fix: This change resolves an issue where the restorecon utility would incorrectly relabel files within these container storage directories, changing their security context from container_ro_file_t to data_home_t.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

…1253682) For some reason it is not listed in the file contexts, so it will show up as to be relabelled when running "restorecon": Would relabel /home/foo/.local/share/containers/storage/overlay-containers/f857f27662ab22b7c502a531d61790b7c120dbedc70820962bb45c285aa03cc3/userdata/artifacts from unconfined_u:object_r:container_ro_file_t:s0 to unconfined_u:object_r:data_home_t:s0 Would relabel /home/foo/.local/share/containers/storage/overlay-containers/2b562de7757133521824ac9de932ddd4862d8262695998a4ee02094c14fc1277/userdata/artifacts from unconfined_u:object_r:container_ro_file_t:s0 to unconfined_u:object_r:data_home_t:s0 <driver>-containers is defined here: https://github.com/containers/storage/blame/83cf57466529353aced8f1803f2302698e0b5cb7/store.go#L3633 Signed-off-by: Cathy Hu <[email protected]>

gemini-code-assist

Code Review

This pull request correctly adds the missing file contexts for ~/.local/share/containers/storage/overlay-containers and overlay2-containers, which resolves the issue of incorrect relabeling by restorecon. The change is straightforward and necessary. I've added one comment regarding the sorting of entries in container.fc for future maintainability improvements, but it doesn't block this PR.

gemini-code-assist · 2025-12-08T12:35:04Z

container.fc

+HOME_DIR/\.local/share/containers/storage/overlay-containers(/.*)?	 gen_context(system_u:object_r:container_ro_file_t,s0)
+HOME_DIR/\.local/share/containers/storage/overlay2-containers(/.*)?	 gen_context(system_u:object_r:container_ro_file_t,s0)


The placement of these new lines follows the existing reverse-alphabetical sorting of suffixes for the entry pairs (layers, images, containers). However, this ordering is inconsistent with other files like container.if (lines 589-593), which use alphabetical order for these suffixes. For better long-term maintainability, it would be ideal to make the sorting consistent across the policy files. Consider creating a follow-up task to reorder this block alphabetically by suffix (containers, images, layers).

lsm5

LGTM

@haircommander @rhatdan PTAL

openshift-ci · 2025-12-10T14:26:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ca-hu, lsm5, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2025-12-10T14:56:52Z

/lgtm

sourcery-ai bot approved these changes Dec 8, 2025

View reviewed changes

ca-hu force-pushed the main-overlay-label-mismatch branch from 5dae7be to 6e2a14b Compare December 8, 2025 12:34

gemini-code-assist bot reviewed Dec 8, 2025

View reviewed changes

lsm5 approved these changes Dec 10, 2025

View reviewed changes

openshift-ci bot added the approved label Dec 10, 2025

openshift-ci bot assigned haircommander Dec 10, 2025

openshift-ci bot added the lgtm label Dec 10, 2025

openshift-merge-bot bot merged commit 9c3cc4c into containers:main Dec 10, 2025
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ~/.local/share/containers/storage/overlay-containers to .fc (bsc#… #424

Add ~/.local/share/containers/storage/overlay-containers to .fc (bsc#… #424

Uh oh!

ca-hu commented Dec 8, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Dec 8, 2025 •

edited

Loading

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot commented Dec 8, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 8, 2025

Uh oh!

lsm5 left a comment

Uh oh!

openshift-ci bot commented Dec 10, 2025

Uh oh!

haircommander commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		HOME_DIR/\.local/share/containers/storage/overlay-containers(/.*)? gen_context(system_u:object_r:container_ro_file_t,s0)
		HOME_DIR/\.local/share/containers/storage/overlay2-containers(/.*)? gen_context(system_u:object_r:container_ro_file_t,s0)

Add ~/.local/share/containers/storage/overlay-containers to .fc (bsc#… #424

Add ~/.local/share/containers/storage/overlay-containers to .fc (bsc#… #424

Uh oh!

Conversation

ca-hu commented Dec 8, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot commented Dec 8, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

lsm5 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Dec 10, 2025

Uh oh!

haircommander commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ca-hu commented Dec 8, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 8, 2025 •

edited

Loading