Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions container.fc
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@
/usr/s?bin/buildkitd.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/local/s?bin/buildkitd.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)

/usr/s?bin/incus-.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/s?bin/incus -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/s?bin/lxc-.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/s?bin/lxd-.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/s?bin/lxc -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/s?bin/lxd -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/s?bin/fuidshift -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/libexec/incus/.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/libexec/lxc/.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/libexec/lxd/.* -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
/usr/bin/podman -- gen_context(system_u:object_r:container_runtime_exec_t,s0)
Expand Down Expand Up @@ -53,6 +56,7 @@
/usr/local/lib/docker/[^/]*plugin -- gen_context(system_u:object_r:container_runtime_exec_t,s0)

/usr/lib/systemd/system/docker.* -- gen_context(system_u:object_r:container_unit_file_t,s0)
/usr/lib/systemd/system/incus.* -- gen_context(system_u:object_r:container_unit_file_t,s0)
/usr/lib/systemd/system/lxd.* -- gen_context(system_u:object_r:container_unit_file_t,s0)
/usr/lib/systemd/system/containerd.* -- gen_context(system_u:object_r:container_unit_file_t,s0)
/usr/lib/systemd/system/buildkit.* -- gen_context(system_u:object_r:container_unit_file_t,s0)
Comment on lines 58 to 62

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to keep these entries sorted alphabetically. Also, the tab alignment for the new incus entry is inconsistent with the rest of the block. I've suggested a change to fix both.

/usr/lib/systemd/system/buildkit.*\t\t--\tgen_context(system_u:object_r:container_unit_file_t,s0)\n/usr/lib/systemd/system/containerd.*\t\t--\tgen_context(system_u:object_r:container_unit_file_t,s0)\n/usr/lib/systemd/system/docker.*\t\t--\tgen_context(system_u:object_r:container_unit_file_t,s0)\n/usr/lib/systemd/system/incus.*\t\t--\tgen_context(system_u:object_r:container_unit_file_t,s0)\n/usr/lib/systemd/system/lxd.*\t\t--\tgen_context(system_u:object_r:container_unit_file_t,s0)

Expand All @@ -66,6 +70,7 @@

/var/lib/shared(/.*)? gen_context(system_u:object_r:container_ro_file_t,s0)
/var/lib/registry(/.*)? gen_context(system_u:object_r:container_var_lib_t,s0)
/var/lib/incus(/.*)? gen_context(system_u:object_r:container_var_lib_t,s0)
/var/lib/lxc(/.*)? gen_context(system_u:object_r:container_var_lib_t,s0)
/var/lib/lxd(/.*)? gen_context(system_u:object_r:container_var_lib_t,s0)
/var/lib/docker(/.*)? gen_context(system_u:object_r:container_var_lib_t,s0)
Comment on lines 72 to 76

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to keep these entries sorted alphabetically.

/var/lib/docker(/.*)?\tgen_context(system_u:object_r:container_var_lib_t,s0)\n/var/lib/incus(/.*)?\tgen_context(system_u:object_r:container_var_lib_t,s0)\n/var/lib/lxc(/.*)?\tgen_context(system_u:object_r:container_var_lib_t,s0)\n/var/lib/lxd(/.*)?\tgen_context(system_u:object_r:container_var_lib_t,s0)\n/var/lib/registry(/.*)?\tgen_context(system_u:object_r:container_var_lib_t,s0)

Expand Down Expand Up @@ -127,6 +132,8 @@ HOME_DIR/\.local/share/containers/storage/volumes/[^/]*/.* gen_context(system_u:

/run/kata-containers(/.*)? gen_context(system_u:object_r:container_kvm_var_run_t,s0)

/var/cache/incus(/.*)? gen_context(system_u:object_r:container_var_lib_t,s0)

/var/local-path-provisioner(/.*)? gen_context(system_u:object_r:container_file_t,s0)
/opt/local-path-provisioner(/.*)? gen_context(system_u:object_r:container_file_t,s0)

Expand Down Expand Up @@ -164,9 +171,14 @@ HOME_DIR/\.local/share/containers/storage/volumes/[^/]*/.* gen_context(system_u:
/srv/containers(/.*)? gen_context(system_u:object_r:container_file_t,s0)
/var/srv/containers(/.*)? gen_context(system_u:object_r:container_file_t,s0)

/run/incus/unix.socket(.*)? -s gen_context(system_u:object_r:container_var_run_t,s0)
/run/incus(/.*)? gen_context(system_u:object_r:container_var_run_t,s0)
/run/lock/lxc(/.*)? gen_context(system_u:object_r:container_lock_t,s0)

/var/log/kube-apiserver(/.*)? gen_context(system_u:object_r:container_log_t,s0)

/var/log/incus(/.*)? gen_context(system_u:object_r:container_log_t,s0)
/var/log/lxc(/.*)? gen_context(system_u:object_r:container_log_t,s0)
/var/log/lxd(/.*)? gen_context(system_u:object_r:container_log_t,s0)
Comment on lines 178 to 182

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to keep these entries sorted alphabetically.

/var/log/incus(/.*)?\t\tgen_context(system_u:object_r:container_log_t,s0)\n/var/log/kube-apiserver(/.*)?\t\tgen_context(system_u:object_r:container_log_t,s0)\n/var/log/lxc(/.*)?\t\tgen_context(system_u:object_r:container_log_t,s0)\n/var/log/lxd(/.*)?\t\tgen_context(system_u:object_r:container_log_t,s0)


/etc/kubernetes(/.*)? gen_context(system_u:object_r:kubernetes_file_t,s0)