-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(precompilation): support streaming layer content in 15MB chunks #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added one open question and one refactoring tip.
- Streams content to the containerd store in 15MB chunks in order to support precompiling larger layers Signed-off-by: Kate Goldenring <[email protected]>
f049f7f
to
9f2c474
Compare
Just pushed a inline doc nit change to add a reference to the containerd max gRPC message size (#507 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I will merge this by the EOD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
lgtm
Going to merge this so that the spin shim can use the commit from |
Streams content to the containerd store in 15MB chunks in order to support precompiling larger layers
Tested with 200 MB Spin app