Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(precompilation): support streaming layer content in 15MB chunks #507

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

kate-goldenring
Copy link
Contributor

Streams content to the containerd store in 15MB chunks in order to support precompiling larger layers

Tested with 200 MB Spin app

Mossaka
Mossaka previously approved these changes Mar 7, 2024
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added one open question and one refactoring tip.

- Streams content to the containerd store in 15MB chunks in order
to support precompiling larger layers

Signed-off-by: Kate Goldenring <[email protected]>
@kate-goldenring
Copy link
Contributor Author

Just pushed a inline doc nit change to add a reference to the containerd max gRPC message size (#507 (comment))

@Mossaka Mossaka linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will merge this by the EOD.

Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

lgtm

@Mossaka
Copy link
Member

Mossaka commented Mar 7, 2024

Going to merge this so that the spin shim can use the commit from main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Writing Large files to containerd content store
4 participants