-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device-injector: remove unreachable code. #115
Conversation
for code changes, no questions, but for go.mod changes, I think it should be not part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core changes, IOW the removal of unreachable code is fine. But there are also a few seemingly unrelated dependency changes and an incorrect-looking update to a comment-directive tossed in there as well. I wonder if the deps changes are unintentional and the directive change, too....
Signed-off-by: cormick <[email protected]>
well, it's unintentional change and i revert it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.