Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device-injector: remove unreachable code. #115

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

CormickKneey
Copy link
Contributor

No description provided.

@kad
Copy link

kad commented Oct 16, 2024

for code changes, no questions, but for go.mod changes, I think it should be not part of this PR.

examples/go.mod Outdated Show resolved Hide resolved
examples/go.mod Outdated Show resolved Hide resolved
pkg/api/update.go Outdated Show resolved Hide resolved
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core changes, IOW the removal of unreachable code is fine. But there are also a few seemingly unrelated dependency changes and an incorrect-looking update to a comment-directive tossed in there as well. I wonder if the deps changes are unintentional and the directive change, too....

@CormickKneey
Copy link
Contributor Author

The core changes, IOW the removal of unreachable code is fine. But there are also a few seemingly unrelated dependency changes and an incorrect-looking update to a comment-directive tossed in there as well. I wonder if the deps changes are unintentional and the directive change, too....

well, it's unintentional change and i revert it...

@klihub klihub self-requested a review October 23, 2024 09:08
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@klihub klihub requested a review from fuweid October 23, 2024 09:09
@klihub klihub changed the title chore: remove unreachable code and fmt files device-injector: remove unreachable code. Oct 23, 2024
@samuelkarp samuelkarp merged commit 44ecabb into containerd:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants