Add cgroupV2 CPUQuotaPeriodUSec support #367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
add-cgroupv2-cpu-quota-period-usec
branch
from
63d749b to
0de39be
Compare
|
Looks like might need to resolve CI running on Ubuntu 20 runners, but IDK if there are any tests we can add for this property? |
austinvazquez
force-pushed
the
add-cgroupv2-cpu-quota-period-usec
branch
from
0de39be to
ce7fe66
Compare
austinvazquez
force-pushed
the
add-cgroupv2-cpu-quota-period-usec
branch
3 times, most recently
from
7e60dce to
0825bd5
Compare
|
I was able to add some unit tests for the property and CI is now only failing due to Ubuntu 20 runner no longer being available from GitHub. |
pendo324
approved these changes
May 20, 2025
henry118
reviewed
May 21, 2025
cgroup2/manager.go
Outdated
| if sdVer := systemdVersion(conn); sdVer >= 242 { | ||
| properties = append(properties, newSystemdProperty("CPUQuotaPeriodUSec", period)) | ||
| } else { | ||
| log.G(context.TODO()).WithField("version", sdVer).Debug("Systemd version is too old to support CPUQuotaPeriodUSec (setting will still be applied to cgroupfs)") |
There was a problem hiding this comment.
What does "setting will still be applied to cgroupfs" mean?
There was a problem hiding this comment.
Oop, good catch that was a bad copy from opencontainers/cgroups where that library has the cgroupfs fallback and writing some properites to file when not supported by systemd.
cgroup2/manager_test.go
Outdated
| require.NoError(t, err, "failed to connect to systemd") | ||
| defer conn.Close() | ||
|
|
||
| sdVer := systemdVersion(conn) |
There was a problem hiding this comment.
suggest perform this check at the beginning so the entire test can be skipped earlier
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-cgroupv2-cpu-quota-period-usec
branch
from
0825bd5 to
75313b9
Compare
|
Needs #368 |
henry118
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #365
This change adds
CPUQuotaPeriodUSecproperty for cgroupsv2. Heavily influenced by github.com/opencontainers/cgroups. Refactors a bit of the existing functions for testability.Added some unit tests for validating the property is properly set.