Disabled arm64 builds

connectedcars · Oct 31, 2024 · 6c8ca4d · 6c8ca4d
1 parent 3e9c2ec
commit 6c8ca4d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/build-all.sh b/build-all.sh
@@ -6,7 +6,9 @@ NODE_STABLE="20"
 NODE_VERSIONS=${NODE_VERSIONS:="22.11.0 20.18.0 18.20.4"}
 YARN_VERSION=${YARN_VERSION:="1.22.19"}
 NPM_VERSION=${NPM_VERSION:="10.9.0"}
+# Disabled arm builds for now as they're only used locally
 BUILD_PLATFORMS=${BUILD_PLATFORMS:='linux/amd64 linux/arm64'}
+# BUILD_PLATFORMS=${BUILD_PLATFORMS:='linux/amd64 linux/arm64'}
 
 # External variables
 PROJECT_ID=${PROJECT_ID:-}
@@ -58,6 +60,7 @@ for NODE_VERSION in $NODE_VERSIONS; do
         docker buildx build --platform="${PLATFORM}" --progress=plain --target=builder --load --tag="europe-west1-docker.pkg.dev/connectedcars-build/node-builder/${BRANCH_NAME}:${NODE_VERSION}" ${DOCKER_NODE_BUILD_ARGS} .
         docker buildx build --platform="${PLATFORM}" --progress=plain --target=fat-base --load --tag="europe-west1-docker.pkg.dev/connectedcars-build/node-fat-base/${BRANCH_NAME}:${NODE_VERSION}" ${DOCKER_NODE_BUILD_ARGS} .
 
+        # These builds are no longer necessary since we use buildx
         # echo "Building test image with old docker build for node $NODE_VERSION for $PLATFORM"
         # DOCKER_BUILDKIT=0 docker build --platform="${PLATFORM}" --tag="test:${NODE_VERSION}" --build-arg=NODE_VERSION="${NODE_VERSION}" --build-arg=BRANCH_NAME="${BRANCH_NAME}" --build-arg=NPM_TOKEN="${NPM_TOKEN}" -f test/Dockerfile.old test/
         # echo "Running test image for node $NODE_VERSION for $PLATFORM"