ci: set least-privilege workflow permissions - #11
Conversation
The conforma org default workflow token permission is now `read` (EC-2145). This workflow declared no `permissions:` block, so it relied on the implicit default token. Add an explicit least-privilege `permissions:` block granting only `contents: read` — the single scope `actions/checkout` needs (uploads and test steps require no token scopes) — so its intent is explicit and robust regardless of the org default. Co-Authored-By: Claude <noreply@anthropic.com> Ref: EC-2171
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe ShellSpec GitHub Actions workflow now explicitly grants read-only access to repository contents. ChangesShellSpec workflow permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The workflow now uses an explicit read-only repository permission for its checkout step. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
PR Summary by QodoSet least-privilege permissions for ShellSpec workflow
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
What
Add an explicit least-privilege
permissions:block (contents: read) tothis workflow.
Why
Follow-up to EC-2145 (conforma org default workflow permissions set to
read). This workflow had nopermissions:block and relied on the implicitdefault token.
contents: readis the only scope it needs (actions/checkout);uploads and test steps require no
GITHUB_TOKENscopes. Scoping it explicitlyfollows least-privilege and addresses the review feedback that
read-allisbroader than necessary.
Co-Authored-By: Claude noreply@anthropic.com
Ref: EC-2171