Skip to content

chore(EC-2174): bump conforma/cli and fix transitive dependency conflicts - #1831

Merged
BohdanMar merged 2 commits into
conforma:mainfrom
BohdanMar:ec-2174-dependency-bump
Sep 9, 2026
Merged

BohdanMar merged 2 commits into
conforma:mainfrom
BohdanMar:ec-2174-dependency-bump

Conversation

@BohdanMar

@BohdanMar BohdanMar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump conforma/cli to include the ec.oci.parsed_blob builtin (EC-1836)
  • Pin knative.dev/eventing to v0.49.2 to fix removed knative.dev/pkg/{metrics,tracing/config} imports
  • Pin gocloud.dev to v0.40.0 to fix removed gocloud.dev/docstore/awsdynamodb import
  • Update schema_test.rego error message to match bumped jsonschema library

Same workaround as conforma/cli commit 4fb63b3.

Blocker for: EC-2081 (use ec.oci.parsed_blob builtin in parsed_blob wrapper)

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fcf98a3e-c2fd-4434-9df5-f8f9d361fba8

📥 Commits

Reviewing files that changed from the base of the PR and between ea1096b and a916bd3.

📒 Files selected for processing (2)
  • acceptance/go.mod
  • docs/go.mod

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 57292c20-1474-45e4-aa07-9030dd529134

📥 Commits

Reviewing files that changed from the base of the PR and between b9c0d95 and ea1096b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates the Go version and module dependencies. It also updates a JSON schema validation test to expect the generic “schema is invalid” error message.

Changes

Dependency and schema validation updates

Layer / File(s) Summary
Go module and dependency refresh
go.mod
The Go version changes to 1.26.7. Direct and indirect dependencies are upgraded, added, removed, or downgraded.
Schema validation test expectation
policy/lib/json/schema_test.rego
The expected error message for an invalid array schema changes to “schema is invalid”.

Priority: ⚪ Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ea109

This updates module dependencies and the expected generic JSON schema validation error message. No concrete merge-blocking impact is identified in the supplied change context.

Suggested reviewers: acepresso

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the dependency updates, their reasons, and related tickets. It does not use the exact What, Why, and Tickets headings, but it provides the required information.
Title check ✅ Passed The title clearly identifies the conforma/cli update and the transitive dependency conflict fix, which are the main changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 3, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:57 AM UTC · Completed 9:10 AM UTC

Commit: ca5794c · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.34

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unit-tests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
policy/lib/json/schema_test.rego 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 3, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Dependency bump PR with large line count driven by go.sum lockfile churn; only 3 files changed with no protected paths, no security-sensitive content, and no CI changes, but elevated dependency signal (2 dep files) and zero test coverage ratio push Tier 1 up; quiet git history with no recent churn or regressions tempers overall risk to moderate.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [dependency_version_management] go.mod — Tekton CLI (tektoncd/cli) downgraded from v0.42.1 to v0.42.0. The PR description justifies other dependency pins (gocloud.dev, knative.dev/eventing) but does not mention this change. Likely a transitive resolution artifact from the conforma/cli v0.9.64 bump, but worth confirming intentionality.

  • [dependency_version_management] go.mod — gocloud.dev pinned at v0.40.0 (down from v0.43.0). Intentional per PR description: fixes removed gocloud.dev/docstore/awsdynamodb import. Same workaround as conforma/cli commit 4fb63b3.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Sep 3, 2026
@joejstuart

Copy link
Copy Markdown
Contributor

I would bump go in all of the go.mod files.

Bump conforma/cli to include the ec.oci.parsed_blob builtin (EC-1836).
Pin knative.dev/eventing to v0.49.2 and gocloud.dev to v0.40.0 to
resolve transitive dependency conflicts where removed packages
(knative.dev/pkg/metrics, knative.dev/pkg/tracing/config,
gocloud.dev/docstore/awsdynamodb) broke go mod tidy.

Update schema_test.rego error message to match the bumped jsonschema
library.

See also conforma/cli commit 4fb63b3 for the same fix in the CLI repo.
@BohdanMar
BohdanMar force-pushed the ec-2174-dependency-bump branch from b9c0d95 to ea1096b Compare September 9, 2026 08:56
@BohdanMar
BohdanMar requested a review from a team as a code owner September 9, 2026 08:56
@BohdanMar

BohdanMar commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

I would bump go in all of the go.mod files.

@joejstuart Thanks for pointing this out, updated.

@BohdanMar
BohdanMar merged commit 0fc0c16 into conforma:main Sep 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate size: XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants