Skip to content

Conversation

eguicf
Copy link
Member

@eguicf eguicf commented May 30, 2025

Summary of Changes

addresses #399

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

  • Tests:
    • Added new
    • Updated existing
    • Deleted existing
  • Have you validated this change locally against a running instance of the Quarkus dev server?
    make quarkus-dev
  • Have you validated this change against a locally running native executable?
    make mvn-package-native && ./target/ide-sidecar-*-runner

@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 19:10
@eguicf eguicf requested a review from a team as a code owner May 30, 2025 19:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Quarkus platform version from 3.15.1 to 3.20.0 to stay up-to-date with the latest framework improvements.

  • Updated Quarkus platform version property

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

Copy link
Contributor

@flippingbits flippingbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating Quarkus, @eguicf. Your PR looks good to me. I have two questions but don't think any changes are needed.

Can we wait with merging this PR into main until the new extension release was published? I'd like to spend some more time using the new Quarkus release in the extension pre-releases before we make it available to users. We could then include it in the next extension release, 1.5.0. WDYT?

@eguicf
Copy link
Member Author

eguicf commented Jun 4, 2025

Thanks for updating Quarkus, @eguicf. Your PR looks good to me. I have two questions but don't think any changes are needed.

Can we wait with merging this PR into main until the new extension release was published? I'd like to spend some more time using the new Quarkus release in the extension pre-releases before we make it available to users. We could then include it in the next extension release, 1.5.0. WDYT?

thank you @flippingbits ! sure, that make sense.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (80.80% Estimated after merge)
  • Duplications No duplication information (0.60% Estimated after merge)

Project ID: ide-sidecar

View in SonarQube

@flippingbits flippingbits self-requested a review June 5, 2025 15:01
Copy link
Contributor

@flippingbits flippingbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @eguicf! I've already approved the PR. Let's wait with merging it until the extension release v1.4.0 is out.

@eguicf eguicf merged commit 075ec4d into main Jun 10, 2025
3 checks passed
@eguicf eguicf deleted the 399 branch June 10, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants