refactor(sdk): remove dead code (RoomManager, GraphSyncAgent) and fix documentation - #469
Merged
Jaydbrown merged 1 commit intoAug 26, 2026
Conversation
… docs - Closes conduit-protocol#440: Remove non-existent contracts/*-abi.ts entry from docs/architecture.md module map - Closes conduit-protocol#441: Update .env.example with comprehensive SDK environment variables and update README.md - Closes conduit-protocol#442: Remove orphaned RoomManager and server.js WebSocket room server along with unused dotenv dependency - Closes conduit-protocol#443: Remove unreachable GraphSyncAgent dead code and its test suite
|
@simplex001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thanks for the contribution here — squash-merging this now. Any follow-ups we'll track in a fresh issue. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #440
Closes #441
Closes #442
Closes #443
Summary of Changes
1. Issue #440 —
Docs: docs/architecture.md's module map references a contracts/*-abi.ts directory that doesn't existcontracts/*-abi.tsentry from the module map indocs/architecture.md.2. Issue #441 —
Docs: root .env.example documents only MAX_ROOM_SIZE and omits every SDK-relevant variableMAX_ROOM_SIZE.env.examplewith a comprehensive SDK environment configuration template documenting all SDK variables (STELLAR_SECRET,NEXT_PUBLIC_NETWORK,CONDUIT_NETWORK,SOROBAN_RPC_URL,CONDUIT_FACTORY_ADDRESS,CONDUIT_GOVERNOR_ADDRESS,CONDUIT_TOKEN_ADDRESS,STREAM_ID,ADDRESS,NEXT_PUBLIC_ADDRESS).README.md's## Configurationsection to document these environment variables and link to.env.example.3. Issue #442 —
Enhancement: src/room-manager.js + src/server.js ship an unrelated WebSocket room server inside the SDK packagesrc/room-manager.js,src/server.js,tests/room-manager.test.js, andsrc/tests/room-manager.test.ts.dotenvfrom productiondependenciesinpackage.jsonand updatedpackage-lock.json.RoomManager (Server Utility)section fromdocs/api.mdand references inREADME.md.4. Issue #443 —
Enhancement: GraphSyncAgent (src/graph-sync-agent.ts) is fully-implemented dead codesrc/graph-sync-agent.tsdead code and its test suitesrc/tests/graph-sync-agent.test.ts.src/graph-sync-agent.tsfrommanualChunksinrollup.config.mjs.5. Changelog
RemovedandDocumentationentries under## [Unreleased]inCHANGELOG.md.Verification
npm run build: Bundled ESM and CJS distributions cleanly.npm test: All 54 test suites and 672 unit tests passed.npm run typecheck: Passed with 0 TypeScript errors.npm run lint: Passed with 0 ESLint errors.