Repository navigation
fix: don't append default headers already set on the request - #286
Draft
Apeksha9389 wants to merge 3 commits into
Draft
Apeksha9389 wants to merge 3 commits into
Apeksha9389 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes conductor-oss/conductor-cli#123
prepareRequestsets the request-specific headers and then appends the defaults fromHttpSettings.HeaderswithHeader.Add, so every JSON request carriesAcceptandContent-Typetwice. The token request intoken_helper.gohas the same pattern. Defaults are now applied only when the request has not already set that header, so request-specific values (e.g.text/plainfor secrets) win.Testing: added
http_requester_test.go, which checks that each header appears once and that a request-specificContent-Typeis kept. I could not rungo testin my environment, so this is a draft until CI passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01S9X4Ebdq8FNMfeYAx71CJi