Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take into account branch, tag or rev on git dependencies #655

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebhmg
Copy link

@sebhmg sebhmg commented Jun 29, 2024

Problem

conda-lock does not take into account rev, branch or tag for a git dependency in pyprojet.toml
See reference in Poetry documentation about specifying the git revision: https://python-poetry.org/docs/dependency-specification/#git-dependencies

It only considers the revision when expressed in the url as url@rev

Fix

Checks both the url and the branch, tag or rev field. Raises an exception in case the information is specified both ways with different values.

@sebhmg sebhmg requested a review from a team as a code owner June 29, 2024 03:58
Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 3d1a62e
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/667f87d931a476000866e3d9
😎 Deploy Preview https://deploy-preview-655--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sebhmg sebhmg force-pushed the support_git_rev branch from 30be661 to 3d1a62e Compare June 29, 2024 04:04
@maresb
Copy link
Contributor

maresb commented Jun 29, 2024

Thanks @sebhmg!

Would you be able to add some tests? You could add them to this pyproject.toml and update this test accordingly,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants