-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags to disable pypi.org and add own private pip repository links #590
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adding a CLI flag to disable PyPI makes a lot of sense to me, and seems straightforward. Are you able to add private repos from |
I do agree that the environment variable substitution for credentials would be very messy. However, I believe that having an additional flag would still provide some value as it would be inconvenient from a user's experience perspective where they would have to carry out any additional actions and edit the environment.yml file before being able to create a lock file from it, especially if they would solely like to add a simple mirror to replace the https://pypi.org link. How do you feel about this? Thank you for your time! |
Hi @maresb do you have any updates on this issue? Thanks! |
I am very happy to see this PR. My server can not consistently connect to @ianpye @maresb what is the status of this PR. If any help is needed, I am happy to contribute. |
I apologize for not finding more time to dedicate to conda-lock and to see through features like this. Glancing over this, it seems very straightforward. I don't think this is problematic. If either of you @ianpye or @Simard302 could rebase this I think I could merge and release it, although it could take some days for me to respond. In general if you're dealing with mixed Conda and pip dependencies I think you'd be better served with pixi. Their support for mixed environments is quite a bit more stable. But I'm not sure how far along they are with private repo support. |
4ff30d1
to
436b16b
Compare
Currently, when creating a conda-lock file using
environment.yml
, poetry will attempt to make a request topypi.org
, with the user being unable to disable it, resulting in a conda-lock exception when used in an environment that does not allow access topypi.org
. It is only currently possible to make such configurations when creating lock files usingpyproject.toml
.With these 2 CLI flags, we will be able to both separately disable requests to pypi.org and add our own private mirror links.