Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multipers #28987

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Add multipers #28987

wants to merge 35 commits into from

Conversation

DavidLapous
Copy link

@DavidLapous DavidLapous commented Jan 30, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/multipers/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: David Loiseaux. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 30, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found some lint.

Here's what I've got...

For recipes/multipers/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13057794287. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 30, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found some lint.

Here's what I've got...

For recipes/multipers/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13071702957. Examine the logs at this URL for more detail.

@DavidLapous
Copy link
Author

Dear @conda-forge/help-python-c

I think this is almost ready, and it seems to build properly on linux + macos.

I have some questions:

  • [disabling windows release] multipers is not yet compatible with windows. I did a
    build:
      skip: true  # [win]
    I hope this is the correct way to do this (I didn't find this part in the doc)
  • [python version] for host, build and run, I added a
     - python >=3.10, <3.13
    
    since multipers requires >=3.10 and a dependency (gudhi) requires <3.13.
    The linter complains with
    Non noarch packages should have python requirement without any version constraints.
    
    but I don't really understand this --- what I added are precisely version constraints.
  • [maintainers] it had an error in the first version, and it is fixed now (although the bot didn't update this).

Also, I have the hand on the source repo, so if changing something there can help this process, feel free to ask for a change there. I plan to make a new release before the end of this process anyway.

Thanks for your help and review !

@synapticarbors
Copy link
Member

You should remove all mentions of python_min/python_max. Those are only for noarch: python recipes, which this is not. When you have packages with platform and version specific builds. Just use python (bare with no selectors) under host, build, run. We build for python 3.9-3.13 currently. If you would need to restrict those to a different range, you'd use the skip field.

recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Show resolved Hide resolved
recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Show resolved Hide resolved
recipes/multipers/LICENSE Outdated Show resolved Hide resolved
recipes/multipers/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found some lint.

Here's what I've got...

For recipes/multipers/meta.yaml:

  • ❌ When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13113057968. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found it was in an excellent condition.

@DavidLapous
Copy link
Author

I bumped the version in the source, which adds (experimental) support for multipers.
It seems that the github workflow shipped corrupted sources to pypi, so I had to put the tarball in the release and set the sources here.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13138271129. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/multipers/meta.yaml) and found it was in an excellent condition.

@DavidLapous
Copy link
Author

DavidLapous commented Feb 4, 2025

Looking at the logs, I think I know who the culprit is for the windows compilation issue; it seems that multipers has troubles compiling with old versions of boost (here libboost-devel=1.84) on windows, which I think are installed here since gudhi is there.

One possibility is simply to remove gudhi from the dependency, or disable the windows build until the next version of gudhi is released. Since windows support on multipers is new, I think I will disable the windows build until it works.

@DavidLapous
Copy link
Author

Another question that I forgot to ask :

During the compilation there is a tbb link. Should I do something to pin the tbb run version to the build version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants