Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding R package poolfstat v3.0.0 #28905

Merged
merged 6 commits into from
Jan 25, 2025
Merged

Conversation

mhoban
Copy link
Contributor

@mhoban mhoban commented Jan 23, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-poolfstat/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-poolfstat/meta.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12920594389. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-poolfstat/meta.yaml) and found it was in an excellent condition.

@mhoban
Copy link
Contributor Author

mhoban commented Jan 23, 2025

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@mhoban
Copy link
Contributor Author

mhoban commented Jan 23, 2025

@conda-forge-admin, please ping conda-forge/help-r

(sorry for the repeat, just getting the hang of this)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-r and so here I am doing that.

@github-actions github-actions bot added the R label Jan 23, 2025
Copy link
Member

@cbrueffer cbrueffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the small license fix.

recipes/r-poolfstat/meta.yaml Outdated Show resolved Hide resolved
@mhoban
Copy link
Contributor Author

mhoban commented Jan 23, 2025

I'm not really sure why the linter failed here? The error given is:

No object found for the path recipes/r-poolfstat

But I don't think that's something I have any control over. The path certainly exists within my branch...

@cbrueffer
Copy link
Member

cbrueffer commented Jan 24, 2025

Seems like an unrelated issue with the linter; other recipes are affected as well and the previous run here looked fine. Not a blocker!

Edit: actually it is a blocker, I can't merge without the lint succeeding ;-) I'll keep an eye on it.

@cbrueffer cbrueffer merged commit ab28172 into conda-forge:main Jan 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants