Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe for bodo #28648

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add recipe for bodo #28648

wants to merge 13 commits into from

Conversation

srilman
Copy link

@srilman srilman commented Dec 19, 2024 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Ref: #28626

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bodo/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12417444786. Examine the logs at this URL for more detail.

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/bodo/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: ehsantn, hadia206, knassre-bodo, IsaacWarren, njriasan, scott-routledge2. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bodo/meta.yaml) and found it was in an excellent condition.

@IsaacWarren
Copy link

I confirm that I am willing to be listed as a maintainer for this recipe.

2 similar comments
@scott-routledge2
Copy link

I confirm that I am willing to be listed as a maintainer for this recipe.

@ehsantn
Copy link

ehsantn commented Dec 19, 2024

I confirm that I am willing to be listed as a maintainer for this recipe.

@njriasan
Copy link

njriasan commented Dec 19, 2024 •
edited
Loading

I confirm that I am willing to be listed as a maintainer for this recipe.

Edit: I am no longer able to be a maintainer. I would like to be removed.

@knassre-bodo
Copy link

I confirm that I am willing to be listed as a maintainer for this recipe.

1 similar comment
@hadia206
Copy link

I confirm that I am willing to be listed as a maintainer for this recipe.

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@srilman
Copy link
Author

srilman commented Dec 20, 2024

@conda-forge/help-python-c, ready for review!

@srilman
Copy link
Author

srilman commented Jan 14, 2025

@conda-forge/help-python-c, bump

@scott-routledge2 scott-routledge2 mentioned this pull request Jan 17, 2025
Draft
5 tasks
@carterbox carterbox closed this Feb 17, 2025
@carterbox carterbox reopened this Feb 17, 2025
carterbox
carterbox requested changes Feb 17, 2025
View reviewed changes
recipes/bodo/meta.yaml Outdated
Comment on lines 100 to 106
- srilman
- ehsantn
- IsaacWarren
- hadia206
- knassre-bodo
- njriasan
- scott-routledge2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see confirmation from srilman, ehsantn, issacwarren, hadia, knrasre, scot-rouledge

njriasan has revoked their consent.

recipes/bodo/meta.yaml Outdated
- IsaacWarren
- hadia206
- knassre-bodo
- njriasan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- njriasan

recipes/bodo/conda_build_config.yaml Outdated
Comment on lines 1 to 21
CONDA_BUILD_SYSROOT:
- /opt/MacOSX10.15.sdk # [osx and x86]
- /opt/MacOSX11.0.sdk # [osx and arm64]

MACOSX_SDK_VERSION: # [osx and x86]
- "10.15" # [osx and x86]

c_stdlib_version: # [osx]
- 10.15 # [osx and x86]
- 11.0 # [osx and arm64]

target_platform:
- osx-arm64 # [osx and arm64]

SDKROOT: # [osx and arm64]
- /opt # [osx and arm64]

c_compiler_version: # [osx]
- 19 # [osx]
cxx_compiler_version: # [osx]
- 19 # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is all to support cross-compilation from x86 to arm OSX. It shouldn't be necessary if you follow our documentation about cross-compilation.

https://conda-forge.org/docs/maintainer/knowledge_base/#cross-compilation

recipes/bodo/conda_build_config.yaml Outdated
Comment on lines 23 to 24
numpy:
- 1.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have channel-wide pinnings for numpy that zip with the python version, but they won't be picked up if you override them here AND/OR add a contraint on numpy in the requirements sections.

recipes/bodo/meta.yaml Outdated
Comment on lines 35 to 36
- cmake
- ninja
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to work when cross-compiling because your build tools will match the target-platform instead of the build-platform.

recipes/bodo/build.sh Outdated
--no-deps --no-build-isolation -vv \
--config-settings=build.verbose=true \
--config-settings=logging.level="DEBUG" \
--config-settings=cmake.args="-DCMAKE_C_COMPILER=$CC;-DCMAKE_CXX_COMPILER=$CXX;-DCMAKE_INSTALL_PREFIX=$PREFIX;-DCMAKE_INSTALL_LIBDIR=lib;-DCMAKE_FIND_ROOT_PATH='$PREFIX;$CONDA_PREFIX_OLD/x86_64-conda-linux-gnu/sysroot';-DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We automatically set at lot of useful/necessary CMAKE arguments in the CMAKE_ARGS environment variable.

https://conda-forge.org/docs/maintainer/knowledge_base/#using-cmake

recipes/bodo/meta.yaml
- numpy >=1.24,<1.27
- pandas >=2.2,<2.3
- fsspec >=2021.09
- libboost-devel =1.85
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the libboost-headers package since it doesn't look like your are linking to libboost.

There are also overdepending warnings from conda-build about zstd and curl.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bodo/meta.yaml) and found some lint.

Here's what I've got...

For recipes/bodo/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13461195082. Examine the logs at this URL for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterbox carterbox carterbox requested changes

Assignees
No one assigned
Labels
Awaiting author contribution python-c
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@srilman @conda-forge-admin @IsaacWarren @scott-routledge2 @ehsantn @njriasan @knassre-bodo @hadia206 @carterbox