-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiformats #28404
Add multiformats #28404
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/multiformats/meta.yaml:
For recipes/multiformats-config/meta.yaml:
For recipes/bases/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12084919273. Examine the logs at this URL for more detail. |
I can help out maintaining from time to time. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/multiformats/meta.yaml:
For recipes/typing-validation/meta.yaml:
For recipes/typing-validation/meta.yaml:
For recipes/bases/meta.yaml:
For recipes/multiformats-config/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12085358290. Examine the logs at this URL for more detail. |
f7e99ff
to
18e6516
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/multiformats/meta.yaml:
For recipes/bases/meta.yaml:
For recipes/typing-validation/meta.yaml:
For recipes/multiformats-config/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12637562428. Examine the logs at this URL for more detail. |
Thanks for your comments! I am not really sure about the |
The variable should be set to a default of 3.9 (the minimal supported version). |
Okay, thanks 👍 I set |
No, you should not set it all. |
Unsetting One hack would be to set |
@conda-forge-admin please rerender (I'm trying to follow this advice.) |
I tried debugging this a little more. I just found by building locally, that the packen
|
Apparently, this issue has already been seen at #28445 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's apparently a hack at #28494, which seems to fix the problem when adding multiple recipes in one PR. Should we try that?
Co-authored-by: Tobias Kölling <[email protected]>
I will close this issue and reopen the PRs for the individual recipes |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).