Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.5 #90

Merged
merged 15 commits into from
Sep 25, 2024
Merged

7.0.5 #90

merged 15 commits into from
Sep 25, 2024

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Aug 27, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@looooo looooo mentioned this pull request Aug 27, 2024
@minrk
Copy link
Member

minrk commented Aug 28, 2024

Does this change the ABI? If so, we'll need to make sure the new builds are not accepted as a dependency for anything built against the old ones (possibly via repodata patches), and may need to add a build variant matrix if there's a reason to keep both.

@looooo
Copy link
Contributor Author

looooo commented Aug 28, 2024

I think so. Maybe someone with more expertise can comment on this.

@Tobias-Fischer
Copy link
Contributor

An easy way to get around potential ABI issues is to bump the version to 7.0.5 in this PR (see #89)

@Tobias-Fischer Tobias-Fischer changed the title Update build-scotch.sh 64 bit support Aug 28, 2024
@looooo
Copy link
Contributor Author

looooo commented Aug 28, 2024

seems like some patches need to be realigned:

Applying patch: /home/conda/recipe_root/0001-Remove-unconditional-testing.patch with args:
['-Np1', '-i', '/tmp/tmp_3no25ar/0001-Remove-unconditional-testing.patch.native', '--binary']
checking file CMakeLists.txt
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored
Warning: failed to download source

@Tobias-Fischer Tobias-Fischer changed the title 64 bit support 7.0.5 + 64 bit support Aug 28, 2024
@Tobias-Fischer
Copy link
Contributor

I've started giving this a go, but I don't have time to resolve the remaining issues, apologies.

@minrk @looooo - do you have capacity to look into this? I might have deleted too many of the old patches.

@Tobias-Fischer Tobias-Fischer mentioned this pull request Aug 29, 2024
3 tasks
@minrk
Copy link
Member

minrk commented Aug 29, 2024

I don't have time right now, but I may be able to next week if nobody else gets to it.

@looooo
Copy link
Contributor Author

looooo commented Aug 31, 2024

I just tested this locally and I still get this error for the pastix-feedstock:

Make Error at CMakeLists.txt:455 (message):
  PASTIX_INT64 is enabled and provided Scotch is not compiled with int64
  support, please build with -DPASTIX_INT64=OFF or install a 64 bits version
  of Scotch.

So my proposal does not fix #88

@Tobias-Fischer
Copy link
Contributor

Looking at their install instructions, I don't think setting any flags is necessary:
https://gitlab.inria.fr/scotch/scotch/-/blob/master/INSTALL.txt?ref_type=heads#L380-386

Are you happy if we remove these changes and merge the pull request so we bump version to 7.0.5 @looooo?

@looooo
Copy link
Contributor Author

looooo commented Sep 23, 2024

@conda-forge-admin, please rerender

@looooo looooo changed the title 7.0.5 + 64 bit support 7.0.5 Sep 23, 2024
@Tobias-Fischer
Copy link
Contributor

Should we merge here @conda-forge/scotch ?

@minrk minrk merged commit 23754ed into conda-forge:main Sep 25, 2024
14 checks passed
@minrk
Copy link
Member

minrk commented Sep 25, 2024

Thank you, @looooo!

@moorepants
Copy link

moorepants commented Sep 26, 2024

I'm getting failures on mac ci runs today with this error:

E   ImportError: dlopen(/Users/runner/miniconda3/envs/test/lib/python3.9/site-packages/ipopt_wrapper.cpython-39-darwin.so, 0x0002): symbol not found in flat namespace '_SCOTCH_errorPrint'

From this PR: csu-hmc/opty#253

@Tobias-Fischer
Copy link
Contributor

Can you please create an issue and fill the template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants