Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to metis 5.1.0 #108

Merged
merged 3 commits into from
Jan 19, 2024
Merged

revert to metis 5.1.0 #108

merged 3 commits into from
Jan 19, 2024

Conversation

akhmerov
Copy link
Contributor

Closes #106

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@akhmerov
Copy link
Contributor Author

@minrk @traversaro this seems to be fairly straightforward, and the build is passing. I've left the metis patch in the repo for future use.

@minrk
Copy link
Member

minrk commented Jan 19, 2024

This will work. Once conda-forge/conda-forge-pinning-feedstock#5397 propagates, specifying the version in meta.yaml shouldn't be necessary and the updated pin should be applied by a rerender.

@akhmerov
Copy link
Contributor Author

Ah, does it mean I should remove the pin?

@minrk
Copy link
Member

minrk commented Jan 19, 2024

Depends on if you want to wait an hour or two for conda-forge-pinning to propagate :)

@minrk
Copy link
Member

minrk commented Jan 19, 2024

Actually, looks like it's ready now. Removing the pin and rerendering applies the 5.1.0 pin

@minrk
Copy link
Member

minrk commented Jan 19, 2024

When this lands, do folks think we're ready to start the migrator for mumps itself? conda-forge/conda-forge-pinning-feedstock#5274

@minrk minrk merged commit ccfb2ce into conda-forge:main Jan 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with metis 5.1.1
2 participants