Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update meta.yaml #18

Merged
merged 13 commits into from
Jan 28, 2025
Merged

update meta.yaml #18

merged 13 commits into from
Jan 28, 2025

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Jan 27, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 27, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package mathics3 using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12982187372. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package mathics3 using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12982363612. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mmatera
Copy link
Contributor Author

mmatera commented Jan 27, 2025

@conda-forge-admin, please rerender

Copy link

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad you are undertaking this!

I looked over the changes and this is a whole new world that I know nothing about. So I can't really offer anything here right now.

@mmatera
Copy link
Contributor Author

mmatera commented Jan 27, 2025

@rocky, I am taking the chance to get this working finally when the release happens in the holidays. The first step it to get Mathics-Scanner on conda-forge. When I get it working, I will try to describe how to do it the next time...

@rocky
Copy link

rocky commented Jan 27, 2025

@rocky, I am taking the chance to get this working finally when the release happens in the holidays. The first step it to get Mathics-Scanner on conda-forge. When I get it working, I will try to describe how to do it the next time...

Thanks! Add the instructions somewhere in the releasing section of the developer's guide.

@conda-forge conda-forge deleted a comment from conda-forge-admin Jan 27, 2025
@mmatera
Copy link
Contributor Author

mmatera commented Jan 27, 2025

@conda-forge/help-python Please give me some advice to fix the win_64 build configuration.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge conda-forge deleted a comment from conda-forge-admin Jan 27, 2025
@mmatera mmatera merged commit ec775fa into conda-forge:main Jan 28, 2025
15 checks passed
run:
- cython >=0.15.1
- Mathics-Scanner >= 1.3.0
- Mathics-Scanner >=1.3.0
Copy link

@rocky rocky Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be >= 1.4.1 given that Mathics 8 is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am update this now. Finally, we have a release in conda-forge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants