Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies and add check for that #110

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Mar 21, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Mar 21, 2024

Weirdly osx-arm64 seems to link to less libraries than the rest of the architectures.

@xhochy
Copy link
Member Author

xhochy commented Apr 9, 2024

@xhochy
Copy link
Member Author

xhochy commented Apr 9, 2024

🤕 glib now depends on gobject-introspection cc @pkgw

@pkgw
Copy link
Contributor

pkgw commented Apr 9, 2024

@xhochy Ugh, that's annoying. I see that you've started working on conda-forge/glib-feedstock#174 ... fingers crossed it's easy to get going!

@xhochy
Copy link
Member Author

xhochy commented Apr 15, 2024

Now running into conda-forge/conda-forge.github.io#2102 (comment)

@pkgw
Copy link
Contributor

pkgw commented Apr 16, 2024

@xhochy It looks like most of these commits about Windows — do you know about the free official Windows VMs? They help me a lot with being able to figure out some of this stuff without needing to wait for the CI over and over again.

@xhochy
Copy link
Member Author

xhochy commented Apr 16, 2024

I know them, but I'm still a bit hesitant to use them. But I think, I have reached a point where I makes sense to use one of them. The actual error we are facing here is that it cannot load a specific DLL during introspection. Sadly, Windows doesn't list the name of the missing DLL.

@pkgw
Copy link
Contributor

pkgw commented Apr 16, 2024

@xhochy Argh, I hate it when that happens! It's a hassle to set up a fresh VM (install Miniforge, Git, VS Code, Visual Studio CLI tools...) and figure out the right incantations (you have to do the Visual Studio activation and stuff like conda build -m .ci_support/win_64_.yaml recipe, AFAICT) but it may well be worth it for diagnosing this kind of thing. I forget exactly how to debug the missing-DLL issue, but I think there's a way to get Windows to tell you what the specific problem actually is.

@xhochy
Copy link
Member Author

xhochy commented Apr 16, 2024

It is actually related to gdk-pixbuf:
image

@xhochy
Copy link
Member Author

xhochy commented Apr 16, 2024

@conda-forge-admin please rerender

recipe/meta.yaml Outdated Show resolved Hide resolved
@xhochy
Copy link
Member Author

xhochy commented Apr 16, 2024

@conda-forge-admin please rerender

@xhochy xhochy marked this pull request as ready for review April 16, 2024 17:57
@xhochy xhochy requested review from pkgw and tschoonj as code owners April 16, 2024 17:57
@xhochy
Copy link
Member Author

xhochy commented Apr 16, 2024

@pkgw Ready for review now 😅

@pkgw
Copy link
Contributor

pkgw commented Apr 16, 2024

@xhochy Would you be OK with tidying up the Git history here? In the end the changes look pretty minimal, but there's a lot of back-and-forth in the history as it is.

@xhochy
Copy link
Member Author

xhochy commented Apr 17, 2024

@pkgw Cleaned up and green

@pkgw pkgw merged commit ceb1e61 into conda-forge:main Apr 17, 2024
8 checks passed
@xhochy xhochy deleted the run_exports branch April 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants