Skip to content

Commit

Permalink
Fix macOS LAMMPS plugin loading issue (#72)
Browse files Browse the repository at this point in the history
automerged PR by conda-forge/automerge-action
  • Loading branch information
github-actions[bot] authored Mar 22, 2024
2 parents 5ec5eae + cb21a78 commit 8f63c8d
Show file tree
Hide file tree
Showing 34 changed files with 77 additions and 71 deletions.
1 change: 1 addition & 0 deletions .azure-pipelines/azure-pipelines-linux.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .azure-pipelines/azure-pipelines-osx.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ c_compiler:
c_compiler_version:
- '12'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
Expand Down Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ c_compiler:
c_compiler_version:
- '12'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
Expand Down Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ c_compiler:
c_compiler_version:
- '12'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
Expand Down Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ c_compiler:
c_compiler_version:
- '12'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
Expand Down Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ c_compiler:
c_compiler_version:
- '12'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
Expand Down Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ c_compiler:
c_compiler_version:
- '12'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
Expand Down Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tensorflow:
zip_keys:
- - c_compiler_version
- cxx_compiler_version
- cdt_name
- cuda_compiler
- cuda_compiler_version
- cdt_name
- docker_image
5 changes: 4 additions & 1 deletion .ci_support/migrations/cuda120.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ cxx_compiler_version: # [linux and os.environ.get("CF_CUDA_ENABLED", "F
fortran_compiler_version: # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]

c_stdlib_version: # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 2.17 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]

cdt_name: # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- cos7 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]

Expand All @@ -87,4 +90,4 @@ docker_image: # [os.environ.get("BUILD_PLAT
- quay.io/condaforge/linux-anvil-aarch64 # [aarch64 and os.environ.get("BUILD_PLATFORM") == "linux-aarch64"]
# case: cross-compilation (build != target)
- quay.io/condaforge/linux-anvil-cos7-x86_64 # [ppc64le and os.environ.get("BUILD_PLATFORM") == "linux-64"]
- quay.io/condaforge/linux-anvil-cos7-x86_64 # [aarch64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
- quay.io/condaforge/linux-anvil-cos7-x86_64 # [aarch64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
6 changes: 3 additions & 3 deletions .scripts/build_steps.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .scripts/run_osx_build.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions build-locally.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions conda-forge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@ github:
branch_name: main
tooling_branch_name: main
test: native_and_emulated
os_version:
linux_64: cos7
linux_aarch64: cos7
linux_ppc64le: cos7
22 changes: 22 additions & 0 deletions recipe/3473.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
From adf640a49cad144d707686e629f24756e28968f6 Mon Sep 17 00:00:00 2001
From: Chenxing Luo <[email protected]>
Date: Sat, 16 Mar 2024 18:53:43 -0400
Subject: [PATCH] Fix LAMMPS plugin symlink path on macOS platform

---
source/lmp/plugin/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/lmp/plugin/CMakeLists.txt b/source/lmp/plugin/CMakeLists.txt
index bfc2253412..4fdae7ac5b 100644
--- a/source/lmp/plugin/CMakeLists.txt
+++ b/source/lmp/plugin/CMakeLists.txt
@@ -126,7 +126,7 @@ if(DEFINED LAMMPS_SOURCE_ROOT OR DEFINED LAMMPS_VERSION)
install(
CODE "execute_process( \
COMMAND ${CMAKE_COMMAND} -E create_symlink \
- ../${CMAKE_SHARED_LIBRARY_PREFIX}${libname}${CMAKE_SHARED_LIBRARY_SUFFIX} \
+ ../${CMAKE_SHARED_MODULE_PREFIX}${libname}${CMAKE_SHARED_MODULE_SUFFIX} \
${CMAKE_INSTALL_PREFIX}/lib/${libname}/${PLUGINNAME} \
)")
endif()
Loading

0 comments on commit 8f63c8d

Please sign in to comment.