Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2.20.0 + update recipe, add myself as maintainer #207

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dbast
Copy link
Member

@dbast dbast commented Jan 31, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@dbast
Copy link
Member Author

dbast commented Jan 31, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 31, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package ddtrace using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13076326892. Examine the logs at this URL for more detail.

conda-forge-webservices[bot] and others added 2 commits January 31, 2025 16:02
@dbast
Copy link
Member Author

dbast commented Jan 31, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package ddtrace using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13076341997. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@zbowling
Copy link
Member

zbowling commented Feb 1, 2025

Looks like we are both trying to get this to work: #206

@zbowling
Copy link
Member

zbowling commented Feb 1, 2025

I'm up to the same failures in my PR too. The logic in ddtrace/internal/datadog/profiling/cmake/FindLibdatadog.cmake is wild with how it does platform matching.

@zbowling
Copy link
Member

zbowling commented Feb 1, 2025

It looks like we will probably have to get a recipe for libdatadog into conda and unvendor how it pulls in a binary version from that gitrepo. They don't provide binary builds for all the archs this recipe supports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants