-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pin for boost #5191
Update pin for boost #5191
Conversation
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/boost and so here I am doing that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've settled into the rhythm of doing this for every fourth version (next would be 1.86)
I thought we were doing every second? |
We've done 1.82, 1.78, 1.74 (pin at the time was 1.70 apparently?), 1.72 (perhaps never closed?) etc. I was just commenting on how we've done it in recent times; I also remember comments (in the core call?) of wanting to keep doing it like that. Personally I'd be OK with doing all even versions, which should also be easier now that we have a proper run-export situation, and that there's a bunch less feedstocks to migrate (because they only depend on the headers now). That said, 1.83 isn't a candidate in either case, and there's still a couple of things about the 1.82 migration that I'm trying to wind down. |
OK. Then, there is simply a difference between ambition and reality.
👍 Let's close this PR. |
So in light of the above discussion, I think we'd be in a position to migrate boost a bit more often than once every ~1.5 years. We did migrate every second version in the past for a while already, and I think we could go back to that, now that the infra has improved a bit. If people agree, I'd be happy to keep an eye on the migration - I got to know most involved feedstocks during the boost 1.82 revamp anyway. Before we merge, I'd like to remove the run-export from CC @conda-forge/core |
Sounds good to me 👍 |
@conda-forge/core, any comments/objections about migrating boost 1.84? |
This was discussed in the last core call - though I couldn't make it. From what I can tell from the notes, there were no objections. Only minuted comment is from @isuruf:
Depends a bit on what "perform the migration" means. If it's until closing the migrator, or until things have stopped percolating (given that there's a tail of dead feedstocks), or something in between. I think arriving at a similar state as we did in #5231 should easily be possible in a month. Also, given boost's 4 month release cadence, the choice between All in all, I'm going to make the change I mentioned above (remove run-export for |
Done in conda-forge/boost-feedstock#189 |
OK, this was waiting for the stdlib-migrator to get ready, and this has happened now, so we can start the first guinea pig migration for the piggyback - very porcine metaphors here, let's hope they fly well! 🐷🙃 |
Thank you for writing #2102: it allows seeing the pig picture. |
This PR has been triggered in an effort to update the pin for boost. The current pinned version is 1.78.0, the latest available version is 1.83.0 and the max pin pattern is x.x.x. This migration will impact 46 feedstocks.
Checklist:
**Please note that if you close this PR we presume that the new pin has been rejected.
@conda-forge-admin please ping boost
This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6980980468, please use this URL for debugging