Skip to content

Commit

Permalink
issue: Disable keepalive to prevent conn failed fprocess restart
Browse files Browse the repository at this point in the history
Resolved: i3840
  • Loading branch information
mikechiuP authored Jul 17, 2020
2 parents c3a634a + 78a7a6f commit da88d5e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions executor/http_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ func makeProxyClient(dialTimeout time.Duration) *http.Client {
Transport: &http.Transport{
Proxy: http.ProxyFromEnvironment,
DialContext: (&net.Dialer{
Timeout: dialTimeout,
KeepAlive: 10 * time.Second,
Timeout: dialTimeout,
// KeepAlive: 10 * time.Second, with server closed conn, upstream error due to not handle ECONNECERROR
}).DialContext,
MaxIdleConns: 100,
MaxIdleConnsPerHost: 100,
DisableKeepAlives: false,
DisableKeepAlives: true,
IdleConnTimeout: 500 * time.Millisecond,
ExpectContinueTimeout: 1500 * time.Millisecond,
},
Expand Down

0 comments on commit da88d5e

Please sign in to comment.