Skip to content

Topics should be lowercase, even proper names, acronyms and initialisms #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Topics should be lowercase, even proper names, acronyms and initialisms #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hooks/conan-center.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,9 @@ def test(out):
if topic in invalid_topics:
out.warn("The topic '{}' is invalid and should be removed from topics "
"attribute.".format(topic))
if topic != topic.lower():
out.warn("The topic '{}' is invalid; even names and acronyms should be formatted "
"entirely in lowercase.".format(topic))


@raise_if_error_output
Expand Down
8 changes: 8 additions & 0 deletions tests/test_hooks/conan-center/test_invalid_topics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,11 @@ def test_invalid_topics(self):
output = self.conan(['export', '.', 'name/version@user/channel'])
self.assertIn("WARN: [INVALID TOPICS (KB-H064)] The topic 'conan' is invalid and should be"
" removed from topics attribute.", output)

def test_uppercase_topics(self):
tools.save('conanfile.py', content=self.conanfile.replace('"foobar",', '"foobar", "Baz", "QUX"'))
output = self.conan(['export', '.', 'name/version@user/channel'])
self.assertIn("WARN: [INVALID TOPICS (KB-H064)] The topic 'Baz' is invalid; even names "
"and acronyms should be formatted entirely in lowercase.", output)
self.assertIn("WARN: [INVALID TOPICS (KB-H064)] The topic 'QUX' is invalid; even names "
"and acronyms should be formatted entirely in lowercase.", output)