Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour code like Conan 1 docs, ensure highlight works #3779

Open
wants to merge 1 commit into
base: develop2
Choose a base branch
from

Conversation

AbrilRBS
Copy link
Member

After talking with @memsharded, this colour scheme looks nicer, it's more prominent to the user that they are reading code

image

The only thing I'm not completely sold on is the highlight colour. I'm open to suggestions! :)

Also, this will only work for the new 2.5 release. Should we backport this to at least 2.4?

@AbrilRBS AbrilRBS requested a review from memsharded June 20, 2024 19:36
@AbrilRBS AbrilRBS assigned AbrilRBS and czoido and unassigned AbrilRBS Jun 20, 2024
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, so finally no light orange, but the most standard light green? Did this already changed in Conan 1 docs? It seems so.

@czoido
Copy link
Contributor

czoido commented Jun 21, 2024

What about using pygments_style = 'default' instead of 'sphinx' and not modifying the highlight color?

image

image

@czoido
Copy link
Contributor

czoido commented Jun 21, 2024

this should go to master to regenerate all the branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants