Add 'python_requires_extend' to the reference. Minor changes to pyreqs docs #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
May 22, 2020
| This is an **experimental** feature subject to breaking changes in future releases. | ||
|
|
||
|
|
||
| This class attribute defines one or more classes that will be injected in runtime as base classes of |
There was a problem hiding this comment.
it would be nice to have an example of syntax of multiple classes specified in python_requires_extend, e.g. should I specify tuple, array, list or something else?
There was a problem hiding this comment.
Now the example uses several python requires.
SSE4
reviewed
May 22, 2020
|
|
||
|
|
||
| This class attribute defines one or more classes that will be injected in runtime as base classes of | ||
| the recipe class. Syntax for each of these classes should be a string like ``pyreq.MyConanfileBase`` |
There was a problem hiding this comment.
also, it's not obvious what's the effect of injection.
e.g. will class Pkg(ConanFile): transform into class Pkg(pyreq.MyConanfileBase):? or will it transform into class Pkg(pyreq.MyConanfileBase, ConanFile) (multiple inheritance)? or something else?
There was a problem hiding this comment.
I've added it to the python_requires section (the linked one)
SSE4
approved these changes
May 26, 2020
memsharded
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1694