Repository navigation
CI: require the OsPath build flag in the build-flags check - #296
Merged
Merged
Conversation
git-annex's OsPath flag is Default: True but not Manual, so when a dependency is missing `Setup configure` silently builds without it. That is how our Ubuntu standalone lost it: the buildenv image lacked file-io >= 0.2.0 (fixed in #295), and nothing noticed because the "expected build flags" check only looked for Assistant, MagicMime, Servant and S3. All four platforms now build with OsPath (latest runs: Ubuntu 36238422515, Windows 36230645908, macOS 36223958127, macOS ARM64 36223802082), so require it everywhere. Edited the template and regenerated the workflows with `make -C .github/workflows/template`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013n9Q2igij49kxdtiakUzYv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
OsPathto the "Check git-annex version for some expected build flags" step, so a build without it fails instead of passing unnoticed.Why
git-annex's
OsPathflag isDefault: Truebut notManual. When one of its dependencies is missing,Setup configurequietly drops it. That is how our Ubuntu standalone lost OsPath: the buildenv image had nofile-io >= 0.2.0(fixed in #295). CI stayed green because the check only looked forAssistant MagicMime Servant S3.Without OsPath, git-annex keeps problems that are only fixed in OsPath builds. Examples are the BeeGFS test failures and file-descriptor leaks to child processes (per the upstream CHANGELOG).
Safe to require on every platform
The latest runs already report OsPath on all four platforms:
… S3 WebDAV Servant OsPath… S3 WebDAV Servant OsPath Blake3 XXH3… S3 WebDAV Servant OsPath Blake3 XXH3… S3 WebDAV Servant OsPath XXH3Changes
.github/workflows/template/build-{{ostype}}.yaml.j2:for f in Assistant MagicMime Servant S3 OsPath.build-*.yamlfiles were regenerated with the repo's ownmake -C .github/workflows/template(mkworkflows.py). Each changed by that one line only; there was no other drift from the template.Testing
FAIL OsPathon the line from before Add file-io 0.2.0 to git-annex build environment #295.Follow-ups (not in this PR)
Ubuntu builds still lack
Blake3andXXH3, which Windows and macOS have, and use aws-0.24.4 while git-annex recommends 0.25.2+. Adding those to the check would first need the buildenv image to provide them.🤖 Generated with Claude Code
https://claude.ai/code/session_013n9Q2igij49kxdtiakUzYv
Generated by Claude Code