Add custom block creation/deletion profile helpers #9
Conversation
| * @see block_add_block_form_submit(). | ||
| */ | ||
| function cm_tools_block_custom_add($admin_label, $title, $body, $body_format = NULL, $region = BLOCK_REGION_NONE, $weight = 0, $settings = array()) { |
There was a problem hiding this comment.
Can we change this to take a big array of options with some nice defaults rather than a huge list of params please?
There was a problem hiding this comment.
It does take an array of options with some nice defaults.
It just also takes the 6 things you'll want to supply every time as separate parameters.
There was a problem hiding this comment.
I felt that this was the right balance.
And I think you'll find that it perfectly conforms to the published CMTools coding conventions
There was a problem hiding this comment.
I could move $region and $weight into settings, to keep it tight I suppose.
I think it would be a bit fruity if all the parameters where in an array.
There was a problem hiding this comment.
I agree, that some consistency between these and cm_tools_block_position() would be pretty sweet actually.
Not to mention moving that function also into profile.inc.
This adds two functions:
cm_tools_block_custom_add()
cm_tools_block_custom_delete()
For adding/removing custom blocks.
It supports the usual core block settings, plus the content_type placement settings provided by the node module.