Skip to content

Add in-queue check for cancelTransaction() in Timelock.sol#213

Open
AmazingAng wants to merge 3 commits intocompound-finance:masterfrom
AmazingAng:master
Open

Add in-queue check for cancelTransaction() in Timelock.sol#213
AmazingAng wants to merge 3 commits intocompound-finance:masterfrom
AmazingAng:master

Conversation

@AmazingAng
Copy link
Copy Markdown

@AmazingAng AmazingAng commented Aug 12, 2022

Add in-queue check for cancelTransaction() in Timelock.sol :

        require(queuedTransactions[txHash], "Timelock::cancelTransaction: Transaction hasn't been queued.");

before deleting the transaction from the queue:

        queuedTransactions[txHash] = false;

Link to #214

@AmazingAng
Copy link
Copy Markdown
Author

  1. Delete import SafeMath, since SafeMath is no longer needed starting with Solidity 0.8.
  2. Delete keyword "public" in constructor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant