Skip to content

Improve security of Comptroller#_supportMarket #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TRiLeZ wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve security of Comptroller#_supportMarket #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fef1c9
Improve security of Comptroller#_supportMarket
TRiLeZ Feb 3, 2022
eb11f77
Fix compilation error
TRiLeZ Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contracts/Comptroller.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,9 @@ contract Comptroller is ComptrollerV7Storage, ComptrollerInterface, ComptrollerE
* @return uint 0=success, otherwise a failure. (See enum Error for details)
*/
function _supportMarket(CToken cToken) external returns (uint) {
if (msg.sender != admin) {
// 1. Ensure the sender is the admin of the Comptroller
// 2. Ensure the admin of the cToken is the admin of the Comptroller
if (/* 1. */ msg.sender != admin || /* 2. */ cToken.admin() != admin) {
return fail(Error.UNAUTHORIZED, FailureInfo.SUPPORT_MARKET_OWNER_CHECK);
}

Expand Down