- 
                Notifications
    You must be signed in to change notification settings 
- Fork 74
Make ViewController open #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            tomaszpieczykolan
  wants to merge
  9
  commits into
  compnerd:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
tomaszpieczykolan:open_viewcontroller
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Draft
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            9 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      94810ca
              
                Make ViewController open
              
              
                tomaszpieczykolan 888aa38
              
                Add an empty test class for ViewController
              
              
                tomaszpieczykolan 75ee951
              
                Add tests for loading the view of ViewController
              
              
                tomaszpieczykolan a652ac8
              
                Add tests for the title getter and setter of ViewController
              
              
                tomaszpieczykolan 36e8f4f
              
                Add MockViewController
              
              
                tomaszpieczykolan c444831
              
                Add tests for disablesAutomaticKeyboardDismissal
              
              
                tomaszpieczykolan 812999e
              
                Add tests for next responder
              
              
                tomaszpieczykolan f86e932
              
                Add tests for viewDidLoad
              
              
                tomaszpieczykolan 6b9c15d
              
                Rename sut to vc
              
              
                tomaszpieczykolan File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| // Copyright © 2021 Saleem Abdulrasool <[email protected]> | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
|  | ||
| import XCTest | ||
|         
                  tomaszpieczykolan marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
| @testable import SwiftWin32 | ||
|  | ||
| final class ViewControllerTests: XCTestCase { | ||
| func testLazyViewLoading() { | ||
| let vc = ViewController() | ||
|  | ||
| XCTAssertNil(vc.viewIfLoaded) | ||
| XCTAssertFalse(vc.isViewLoaded) | ||
|  | ||
| _ = vc.view | ||
|  | ||
| XCTAssertNotNil(vc.viewIfLoaded) | ||
| XCTAssertTrue(vc.isViewLoaded) | ||
| } | ||
|  | ||
| func testManualViewLoading() { | ||
| let vc = ViewController() | ||
|  | ||
| XCTAssertNil(vc.viewIfLoaded) | ||
| XCTAssertFalse(vc.isViewLoaded) | ||
|  | ||
| vc.loadViewIfNeeded() | ||
|  | ||
| XCTAssertNotNil(vc.viewIfLoaded) | ||
| XCTAssertTrue(vc.isViewLoaded) | ||
| } | ||
|  | ||
| func testTitleGetterAndSetter() { | ||
| let vc = ViewController() | ||
|  | ||
| // XCTAssertNil(vc.title) // This is currently failing, but the initial value of `title` should be `nil` | ||
|  | ||
| vc.title = "Title" | ||
|  | ||
| XCTAssertEqual(vc.title, "Title") | ||
| } | ||
|  | ||
| func testValueOfDisablesAutomaticKeyboardDismissal() { | ||
| let vc = MockViewController() | ||
|  | ||
| vc.modalPresentationStyleGetter = { | ||
| return .automatic | ||
| } | ||
|  | ||
| XCTAssertFalse(vc.disablesAutomaticKeyboardDismissal) | ||
|  | ||
| vc.modalPresentationStyleGetter = { | ||
| return .formSheet | ||
| } | ||
|  | ||
| XCTAssertTrue(vc.disablesAutomaticKeyboardDismissal) | ||
| } | ||
|  | ||
| func testNextResponder() { | ||
| let expectedResult = View(frame: .zero) | ||
|  | ||
| let vc = ViewController() | ||
|  | ||
| XCTAssertNil(vc.next) | ||
|  | ||
| expectedResult.addSubview(vc.view) | ||
|  | ||
| XCTAssert(vc.next === expectedResult) | ||
| } | ||
|  | ||
| func testViewDidLoadMethodCalledAfterLazyViewLoad() { | ||
| let vc = MockViewController() | ||
|  | ||
| let expectation = self.expectation(description: "viewDidLoad should be called") | ||
|  | ||
| vc.viewDidLoadBlock = { | ||
| expectation.fulfill() | ||
| } | ||
|  | ||
| _ = vc.view | ||
|  | ||
| wait(for: [expectation], timeout: 0.1) | ||
| } | ||
|  | ||
| func testViewDidLoadMethodCalledAfterManualViewLoad() { | ||
| let vc = MockViewController() | ||
|  | ||
| let expectation = self.expectation(description: "viewDidLoad should be called") | ||
|  | ||
| vc.viewDidLoadBlock = { | ||
| expectation.fulfill() | ||
| } | ||
|  | ||
| vc.loadViewIfNeeded() | ||
|  | ||
| wait(for: [expectation], timeout: 0.1) | ||
|         
                  tomaszpieczykolan marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
| } | ||
|  | ||
| func testViewDidLoadMethodNotCalledIfViewNotLoaded() { | ||
| let vc = MockViewController() | ||
|  | ||
| let expectation = self.expectation(description: "viewDidLoad should not be called") | ||
| expectation.isInverted = true | ||
|  | ||
| vc.viewDidLoadBlock = { | ||
| expectation.fulfill() | ||
| } | ||
|  | ||
| wait(for: [expectation], timeout: 0.1) | ||
| } | ||
| } | ||
|  | ||
| final class MockViewController: ViewController { | ||
| var modalPresentationStyleGetter: () -> ModalPresentationStyle = { | ||
| XCTFail("Not implemented") | ||
| return .automatic | ||
| } | ||
|  | ||
| var modalPresentationStyleSetter: (ModalPresentationStyle) -> Void = { _ in | ||
| XCTFail("Not implemented") | ||
| } | ||
|  | ||
| var viewDidLoadBlock: () -> Void = { | ||
| XCTFail("Not implemented") | ||
| } | ||
|  | ||
| override var modalPresentationStyle: ModalPresentationStyle { | ||
| get { | ||
| return modalPresentationStyleGetter() | ||
| } | ||
| set { | ||
| modalPresentationStyleSetter(newValue) | ||
| } | ||
| } | ||
|  | ||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| viewDidLoadBlock() | ||
| } | ||
| } | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.