[wip] Added undo operation for xeus-cpp #293
Conversation
kr-2003
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| try | ||
| { | ||
| n = std::stoi(code.substr(6)); |
There was a problem hiding this comment.
warning: no header providing "std::stoi" is directly included [misc-include-cleaner]
n = std::stoi(code.substr(6));
^| { | ||
| n = std::stoi(code.substr(6)); | ||
| } | ||
| catch (const std::invalid_argument&) |
There was a problem hiding this comment.
warning: no header providing "std::invalid_argument" is directly included [misc-include-cleaner]
src/xinterpreter.cpp:20:
- #ifndef EMSCRIPTEN
+ #include <stdexcept>
+ #ifndef EMSCRIPTEN| } | ||
| catch (const std::invalid_argument&) | ||
| { | ||
| throw std::runtime_error( |
There was a problem hiding this comment.
warning: no header providing "std::runtime_error" is directly included [misc-include-cleaner]
throw std::runtime_error(
^| "Invalid format for %undo. Expected '%undo n' where n is an integer." | ||
| ); | ||
| } | ||
| catch (const std::out_of_range&) |
There was a problem hiding this comment.
warning: no header providing "std::out_of_range" is directly included [misc-include-cleaner]
catch (const std::out_of_range&)
^| throw std::runtime_error("Number out of range for %undo."); | ||
| } | ||
| } | ||
| compilation_result = Cpp::Undo(n) ? true : false; |
There was a problem hiding this comment.
warning: no member named 'Undo' in namespace 'Cpp' [clang-diagnostic-error]
compilation_result = Cpp::Undo(n) ? true : false;
^| throw std::runtime_error("Number out of range for %undo."); | ||
| } | ||
| } | ||
| compilation_result = Cpp::Undo(n) ? true : false; |
There was a problem hiding this comment.
warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]
| compilation_result = Cpp::Undo(n) ? true : false; | |
| compilation_result = Cpp::static_cast<bool>(Undo(n)); |
| } | ||
| else | ||
| { | ||
| compilation_result = Cpp::Process(code.c_str()); |
There was a problem hiding this comment.
warning: no header providing "Cpp::Process" is directly included [misc-include-cleaner]
compilation_result = Cpp::Process(code.c_str());
^
|
Maybe you can add a couple tests ? |
Sure. |
Description
Undo last N operations.
Fixes #263