add IsCUDAFunction
#745
Open
add IsCUDAFunction
#745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Decl* D = static_cast<Decl*>(scope); | ||
| if (auto *FD = llvm::dyn_cast<FunctionDecl>(D)) { | ||
| for (const auto &i: FD->attrs()) { | ||
| if (i->getKind() == clang::attr::Kind::CUDAGlobal) |
Contributor
There was a problem hiding this comment.
warning: no header providing "clang::attr::Kind" is directly included [misc-include-cleaner]
lib/CppInterOp/CppInterOp.cpp:41:
- #if CLANG_VERSION_MAJOR >= 19
+ #include <clang/Basic/AttrKinds.h>
+ #if CLANG_VERSION_MAJOR >= 19
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 79.04% 78.89% -0.15%
==========================================
Files 9 9
Lines 3879 3886 +7
==========================================
Hits 3066 3066
- Misses 813 820 +7
🚀 New features to boost your workflow:
|
Vipul-Cariappa
force-pushed
the
dev/IsCUDAFunction
branch
from
29b9f9d to
6fe5ccc
Compare
Collaborator
|
@Vipul-Cariappa We don't currently have a ci job which can test cuda related stuff. The self hosted runners Clad uses for this are already subscribed (CppInterOp technically has them available, but I never put them to use for this reason). If you add a test I can check your changes locally though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
Testing
Checklist