Simplify getenv call using cstdlib #709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
approved these changes
Sep 10, 2025
|
CI isn't happy. Looks like double free? (reference: https://github.com/compiler-research/CppInterOp/actions/runs/17621310446/job/50070564052?pr=709#step:12:725). |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
There might be some chances that the failures are not introduced by this PR; instead, it is due to the thread-safety PR. Will need to do some local testing to figure it out. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially reverts c0a4dfe#diff-9e2485d191b0ee5c98436db2e99b854b71c96f67cb1d8b42870744ffbbe31acc
Is motivated by root-project/root#19864
Type of change
Simplification
Testing
see ROOT CI PR
Checklist