fix JitCall codegen for duplicate symbols within namespaces #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
force-pushed
the
dev/namespaced-duplicate
branch
from
8ec0991 to
06e4b57
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 79.68% 79.69% +0.01%
==========================================
Files 9 9
Lines 3942 3944 +2
==========================================
+ Hits 3141 3143 +2
Misses 801 801
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@Vipul-Cariappa ignore the failing ci job. Its broken on main too. This other PR you have open fixes this failing job #678 . No idea how. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Fixes 1 test in cppyy
Type of change
Please tick all options which are relevant.
Testing
Checklist