[MRE] successive Declare fails if InstantiateFunctionDefinition fails in MakeFunctionCallable

[Vipul-Cariappa]

This is a bug report.

If the instantiation of a templated function fails while CodeGen (MakeFunctionCallable), then successive call to Cpp::Declare fails.
But a second call to Cpp::Declare will pass.

I suspect something similar to

#ifdef CPPINTEROP_USE_CLING
    cling::Interpreter::PushTransactionRAII RAII(&I);
#endif

is required?

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[Vipul-Cariappa]

Summary of conversion had over discord:
Declare does not print out any error.
The return code says it failed.
Stray Declare(" ") also fails.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (dd50000) to head (58d155a).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   77.66%   77.85%   +0.18%     
==========================================
  Files           9        9              
  Lines        3743     3748       +5     
==========================================
+ Hits         2907     2918      +11     
+ Misses        836      830       -6     

Files with missing lines	Coverage Δ
lib/CppInterOp/CppInterOp.cpp	85.42% <100.00%> (+0.32%)	⬆️

Files with missing lines	Coverage Δ
lib/CppInterOp/CppInterOp.cpp	85.42% <100.00%> (+0.32%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[vgvassilev]

Do we want to move this somewhere in InstantiateTemplate and replace S.InstantiateFunctionDefinition with it?