Skip to content

Add type info interfaces motivated by numba #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add type info interfaces motivated by numba #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions include/clang/Interpreter/CppInterOp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ namespace Cpp {

enum OperatorArity { kUnary = 1, kBinary, kBoth };

enum Signedness { kSigned = 1, kUnsigned, kAny };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: enum 'Signedness' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

  enum Signedness { kSigned = 1, kUnsigned, kAny };
       ^


/// A class modeling function calls for functions produced by the interpreter
/// in compiled code. It provides an information if we are calling a standard
/// function, constructor or destructor.
Expand Down Expand Up @@ -523,15 +525,32 @@ namespace Cpp {
/// Checks if the provided parameter is a Plain Old Data Type (POD).
CPPINTEROP_API bool IsPODType(TCppType_t type);

/// Checks if type has an integer representation
CPPINTEROP_API bool IsIntegerType(TCppType_t type,
Signedness s = Signedness::kAny);

/// Checks if type has a floating representation
CPPINTEROP_API bool IsFloatingType(TCppType_t type);

/// Checks if two types are the equivalent
/// i.e. have the same canonical type
CPPINTEROP_API bool IsSameType(TCppType_t type_a, TCppType_t type_b);

/// Checks if type is a pointer
CPPINTEROP_API bool IsPointerType(TCppType_t type);

/// Checks if type is a void pointer
CPPINTEROP_API bool IsVoidPointerType(TCppType_t type);

/// Get the underlying pointee type
CPPINTEROP_API TCppType_t GetPointeeType(TCppType_t type);

/// Checks if type is a reference
CPPINTEROP_API bool IsReferenceType(TCppType_t type);

/// Get the type handle to the unqualified type
CPPINTEROP_API TCppType_t GetUnqualifiedType(TCppType_t type);

/// Get the type that the reference refers to
CPPINTEROP_API TCppType_t GetNonReferenceType(TCppType_t type);

Expand Down
42 changes: 42 additions & 0 deletions lib/Interpreter/CppInterOp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,11 +1597,44 @@
return QT.isPODType(getASTContext());
}

bool IsIntegerType(TCppType_t type, Signedness s) {
if (!type)
return false;

Check warning on line 1602 in lib/Interpreter/CppInterOp.cpp

View check run for this annotation

Codecov / codecov/patch

lib/Interpreter/CppInterOp.cpp#L1602 

Added line #L1602 was not covered by tests
QualType QT = QualType::getFromOpaquePtr(type);
switch (s) {
case Signedness::kAny:
return QT->hasIntegerRepresentation();

case Signedness::kSigned:
return QT->hasSignedIntegerRepresentation();

case Signedness::kUnsigned:
return QT->hasUnsignedIntegerRepresentation();
}
return false;

Check warning on line 1614 in lib/Interpreter/CppInterOp.cpp

View check run for this annotation

Codecov / codecov/patch

lib/Interpreter/CppInterOp.cpp#L1614 

Added line #L1614 was not covered by tests
}

bool IsFloatingType(TCppType_t type) {
QualType QT = QualType::getFromOpaquePtr(type);
return QT->hasFloatingRepresentation();

Check warning on line 1619 in lib/Interpreter/CppInterOp.cpp

View check run for this annotation

Codecov / codecov/patch

lib/Interpreter/CppInterOp.cpp#L1617-L1619 

Added lines #L1617 - L1619 were not covered by tests
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

    auto *D = (clang::Decl *) var;
              ^


bool IsSameType(TCppType_t type_a, TCppType_t type_b) {
clang::QualType QT1 = clang::QualType::getFromOpaquePtr(type_a);
clang::QualType QT2 = clang::QualType::getFromOpaquePtr(type_b);
return getASTContext().hasSameType(QT1, QT2);
}

bool IsPointerType(TCppType_t type) {
QualType QT = QualType::getFromOpaquePtr(type);
return QT->isPointerType();
}

bool IsVoidPointerType(TCppType_t type) {
QualType QT = QualType::getFromOpaquePtr(type);
return QT->isVoidPointerType();
}

TCppType_t GetPointeeType(TCppType_t type) {
if (!IsPointerType(type))
return nullptr;
Expand All @@ -1621,8 +1654,17 @@
return QT.getNonReferenceType().getAsOpaquePtr();
}

TCppType_t GetUnqualifiedType(TCppType_t type) {
if (!type)
return nullptr;
QualType QT = QualType::getFromOpaquePtr(type);
return QT.getUnqualifiedType().getAsOpaquePtr();

Check warning on line 1661 in lib/Interpreter/CppInterOp.cpp

View check run for this annotation

Codecov / codecov/patch

lib/Interpreter/CppInterOp.cpp#L1657-L1661 

Added lines #L1657 - L1661 were not covered by tests
}

TCppType_t GetUnderlyingType(TCppType_t type)
{
if (!type)
return nullptr;

Check warning on line 1667 in lib/Interpreter/CppInterOp.cpp

View check run for this annotation

Codecov / codecov/patch

lib/Interpreter/CppInterOp.cpp#L1667 

Added line #L1667 was not covered by tests
QualType QT = QualType::getFromOpaquePtr(type);
QT = QT->getCanonicalTypeUnqualified();

Expand Down
108 changes: 108 additions & 0 deletions unittests/CppInterOp/TypeReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,3 +605,111 @@ TEST(TypeReflectionTest, IsFunctionPointerType) {
EXPECT_FALSE(
Cpp::IsFunctionPointerType(Cpp::GetVariableType(Cpp::GetNamed("i"))));
}

TEST(TypeReflectionTest, IntegerTypes) {
Cpp::CreateInterpreter();
std::vector<Decl*> Decls;
std::string code = R"(
int a;
int *b;
double c;
enum A { x, y };
A evar = x;
char k;
long int l;
unsigned int m;
unsigned long n;
)";

GetAllTopLevelDecls(code, Decls);

// Signedness defaults to Any and returns true for both signed and unsigned
// types.
EXPECT_TRUE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[0])));
EXPECT_FALSE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[1])));
EXPECT_FALSE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[2])));
EXPECT_TRUE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[4])));
EXPECT_TRUE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[5])));
EXPECT_TRUE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[6])));
EXPECT_TRUE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[7]),
Cpp::Signedness::kUnsigned));
EXPECT_FALSE(Cpp::IsIntegerType(Cpp::GetVariableType(Decls[8]),
Cpp::Signedness::kSigned));
}

TEST(TypeReflectionTest, VoidPtrType) {
Cpp::CreateInterpreter();
std::vector<Decl*> Decls;
std::string code = R"(
class A {};
using VoidPtrType = void*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'TEST' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change
using VoidPtrType = void*;
TESTstatic (TypeReflectionTest, VoidPtrType) {

VoidPtrType a = nullptr;
void * b = nullptr;
A *pa = nullptr;
)";

GetAllTopLevelDecls(code, Decls);

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetVariableType(Decls[2])),
"VoidPtrType");
EXPECT_TRUE(Cpp::IsVoidPointerType(Cpp::GetVariableType(Decls[2])));
EXPECT_TRUE(Cpp::IsVoidPointerType(Cpp::GetVariableType(Decls[3])));
EXPECT_FALSE(Cpp::IsVoidPointerType(Cpp::GetVariableType(Decls[4])));
}

TEST(TypeReflectionTest, IsSameType) {
Cpp::CreateInterpreter();
std::vector<Decl*> Decls;

std::string code = R"(
#include <cstdarg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'TEST' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change
#include <cstdarg>
TESTstatic (TypeReflectionTest, IsSameType) {

#include <iostream>

typedef std::va_list VaListAlias;
std::va_list va1;
VaListAlias va2;

const int ci = 0;
int const ic = 0;

signed int si1 = 0;
int si2 = 0;

void *x;
)";

GetAllTopLevelDecls(code, Decls);

#include <iostream>

ASTContext& Ctxt = Interp->getCI()->getASTContext();

Decls.assign(Decls.end() - 8, Decls.end());

EXPECT_TRUE(
Cpp::IsSameType(Cpp::GetType("bool"), Ctxt.BoolTy.getAsOpaquePtr()));
EXPECT_TRUE(
Cpp::IsSameType(Cpp::GetType("float"), Ctxt.FloatTy.getAsOpaquePtr()));
EXPECT_TRUE(
Cpp::IsSameType(Cpp::GetType("long"), Ctxt.LongTy.getAsOpaquePtr()));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetType("long long"),
Ctxt.LongLongTy.getAsOpaquePtr()));
EXPECT_TRUE(
Cpp::IsSameType(Cpp::GetType("short"), Ctxt.ShortTy.getAsOpaquePtr()));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetType("char"),
Ctxt.SignedCharTy.getAsOpaquePtr()));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetType("unsigned char"),
Ctxt.UnsignedCharTy.getAsOpaquePtr()));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetType("unsigned int"),
Ctxt.UnsignedIntTy.getAsOpaquePtr()));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetVariableType(Decls[7]),
Ctxt.VoidPtrTy.getAsOpaquePtr()));

// Expect the typedef to std::va_list to be the same type
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetVariableType(Decls[1]),
Cpp::GetVariableType(Decls[2])));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetVariableType(Decls[3]),
Cpp::GetVariableType(Decls[4])));
EXPECT_TRUE(Cpp::IsSameType(Cpp::GetVariableType(Decls[5]),
Cpp::GetVariableType(Decls[6])));
}
Loading