Skip to content

Added external logging #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added external logging #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1cb869
Added external logging
nederer Jun 17, 2025
7cf3bd2
fix ci?
vrslev Aug 4, 2025
0c0553a
fix ci?
vrslev Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions microbootstrap/instruments/logging_instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from __future__ import annotations
from future import annotations
import logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему?

import logging.handlers
import time
Expand Down Expand Up @@ -71,18 +71,29 @@ def tracer_injection(_: WrappedLogger, __: str, event_dict: EventDict) -> EventD
return event_dict


DEFAULT_STRUCTLOG_PROCESSORS: typing.Final[list[typing.Any]] = [
structlog.stdlib.filter_by_level,
structlog.stdlib.add_log_level,
DEFAULT_STRUCTLOG_PRE_CHAIN_PROCESSORS: typing.Final[list[typing.Any]] = [
structlog.stdlib.add_logger_name,
tracer_injection,
structlog.stdlib.add_log_level,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Трейсинг будет полезен во всех логах

structlog.stdlib.PositionalArgumentsFormatter(),
structlog.processors.TimeStamper(fmt="%Y-%m-%d %H:%M:%S"),
structlog.processors.StackInfoRenderer(),
structlog.processors.format_exc_info,
]
DEFAULT_STRUCTLOG_PROCESSORS: typing.Final[list[typing.Any]] = [
*DEFAULT_STRUCTLOG_PRE_CHAIN_PROCESSORS,
structlog.stdlib.filter_by_level,
tracer_injection,
structlog.processors.UnicodeDecoder(),
]
DEFAULT_STRUCTLOG_FORMATTER_PROCESSOR: typing.Final = structlog.processors.JSONRenderer(serializer=orjson.dumps)


def _serialize_log_with_orjson_to_string(value: typing.Any, **kwargs: typing.Any) -> str: # noqa: ANN401
return orjson.dumps(value, **kwargs).decode()


DEFAULT_STRUCTLOG_FORMATTER_PROCESSOR: typing.Final = structlog.processors.JSONRenderer(
serializer=_serialize_log_with_orjson_to_string
)


class MemoryLoggerFactory(structlog.stdlib.LoggerFactory):
Expand Down Expand Up @@ -150,6 +161,8 @@ def bootstrap(self) -> None:
for unset_handlers_logger in self.instrument_config.logging_unset_handlers:
logging.getLogger(unset_handlers_logger).handlers = []

stream_handler: typing.Final = logging.StreamHandler()
root_logger: typing.Final = logging.getLogger()
structlog.configure(
Comment on lines +164 to +165
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай поместим ниже, перед stream_handler.setFormatter(

processors=[
*DEFAULT_STRUCTLOG_PROCESSORS,
Expand All @@ -165,6 +178,17 @@ def bootstrap(self) -> None:
wrapper_class=structlog.stdlib.BoundLogger,
cache_logger_on_first_use=True,
)
stream_handler.setFormatter(
structlog.stdlib.ProcessorFormatter(
foreign_pre_chain=[
*DEFAULT_STRUCTLOG_PRE_CHAIN_PROCESSORS,
structlog.stdlib.ProcessorFormatter.remove_processors_meta,
],
processors=[structlog.processors.JSONRenderer()],
logger=root_logger,
)
)
root_logger.addHandler(stream_handler)

@classmethod
def get_config_type(cls) -> type[LoggingConfig]:
Expand Down
Loading