Frontend list works #57
Conversation
| linkMap.next = url.format(linkUrl); | ||
|
|
||
| if (req.query.page > 1) { | ||
| linkUrl.query.page = req.query.page - 1; | ||
| linkUrl.query.page = current - 1; | ||
| linkMap.previous = url.format(linkUrl); | ||
| } |
There was a problem hiding this comment.
"previous" page was pointing to the current page.
There was a problem hiding this comment.
I don't quite get this: why would req.query.page not work? I tested req.query.page (which is forced to a reasonable number in rest.js) and it seems to work, but I might have missed some use case.
The reason I zoomed in here is that if page isn't included in the URL at all, then current becomes undefined and the paging links break. That is avoided when using req.query.page.
There was a problem hiding this comment.
I assumed that it would either return error or force page to 1 if page wasn't defined. The problem here was that req.query.page was being increased by 1 and then decreased by one, when it should've been decreased by 2. I just liked more to have a "current" var
| @@ -886,6 +886,7 @@ exports.listWorks = function listWorks(context, conditions, sort, skip, limit) { | |||
| } | |||
| ) | |||
| .map(function(work) { | |||
| setWorkPerms(context)(work); | |||
There was a problem hiding this comment.
needed the permissions
Conflicts: frontend/public/app/views/userProfileView.js frontend/styles/style.styl
Ready to test:
- listing and paging works (1st, prev, next)
- filtering and unfiltering by current user id
- removing works
- changing work visibility by batch
- batch selection should be only visible if user has write permission