-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(bump): remove NotAllowed related to --get-next option, and other related refactoring
#1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bearomorphism
wants to merge
9
commits into
commitizen-tools:v4-10-1
Choose a base branch
from
bearomorphism:dev-bump
base: v4-10-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of potential type error
…hook question, simplify logic, remove unreachable code path
…attern more clear
56b9440 to
5cc10ae
Compare
5cc10ae to
cfd13e6
Compare
Contributor
Author
woile
approved these changes
Nov 10, 2025
Member
woile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
|
I just update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes
dry_run = Truewhile we already haveget_next = True. The latter condition raises aGetNextExit()exception in the original code, so no effect if we setdry_runtoTrue. Moreover, the original code isself.dry_run = Truewhich is ineffective since we never use the member variable.get_nexttonext_version_to_stdout. The variable nameget_nextis very unclear and hard to guess what it will do. I think we can consider renaming the option in the next major release.--get-nextwhen changelog is enabled #1640) ReplaceNotAllowedrelated to--get-nextoption with warnings.GetNextExitexception because we already haveDryRunExit.--get-nextis just--dry-runbut doing less things IMO.