Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commands/init): add missing uv provider to "cz init" #1378

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Mar 30, 2025

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@Lee-W
Copy link
Member Author

Lee-W commented Mar 30, 2025

quick fix during some testing. will try to see whether it makes sense to add a test for it.

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.55%. Comparing base (120d514) to head (6c97d55).
Report is 578 commits behind head on master.

Files with missing lines Patch % Lines
commitizen/commands/init.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   97.33%   97.55%   +0.21%     
==========================================
  Files          42       57      +15     
  Lines        2104     2655     +551     
==========================================
+ Hits         2048     2590     +542     
- Misses         56       65       +9     
Flag Coverage Δ
unittests 97.55% <50.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@woile
Copy link
Member

woile commented Apr 3, 2025

We could detect if uv is being used by checking the presence of uv.lock, and set it as default.

@Lee-W
Copy link
Member Author

Lee-W commented Apr 4, 2025

Yep, we should. This PR is somewhat a work in progress (but already fixes something). I'll try to wrap it up today!

@woile woile merged commit 904173e into master Apr 4, 2025
17 of 18 checks passed
@woile woile deleted the fix-missing-uv-provider-in-init branch April 4, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants